Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 844503002: Fix bug in Runtime_CompileOptimized resulting from stack overflow. (Closed)

Created:
5 years, 11 months ago by titzer
Modified:
5 years, 11 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix bug in Runtime_CompileOptimized resulting from stack overflow. R=jarin@chromium.org BUG=chromium:446774 LOG=Y Committed: https://crrev.com/d77d3ba9a355f98e6ff1a421be2741fa897bed63 Cr-Commit-Position: refs/heads/master@{#25974}

Patch Set 1 #

Patch Set 2 : Add test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M src/runtime/runtime-compiler.cc View 1 chunk +12 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-446389.js View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
titzer
5 years, 11 months ago (2015-01-07 13:02:41 UTC) #1
Jarin
lgtm, but add the test, please. Nit: how about using 'BUG=chromium:446389' in the bug description? ...
5 years, 11 months ago (2015-01-07 13:09:04 UTC) #2
titzer
On 2015/01/07 13:09:04, jarin wrote: > lgtm, but add the test, please. > Done. > ...
5 years, 11 months ago (2015-01-07 13:16:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844503002/20001
5 years, 11 months ago (2015-01-07 13:16:47 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-07 13:43:37 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 13:43:55 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d77d3ba9a355f98e6ff1a421be2741fa897bed63
Cr-Commit-Position: refs/heads/master@{#25974}

Powered by Google App Engine
This is Rietveld 408576698