Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: src/utils/debugger/SkDebugCanvas.h

Issue 844493003: Remove incremental draw optimization from SkDebugCanvas (Closed) Base URL: https://skia.googlesource.com/skia.git@debugcanvas-stateless-draw-02-debugger-rasterwidget-update-on-need
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « debugger/SkDebugger.cpp ('k') | src/utils/debugger/SkDebugCanvas.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/utils/debugger/SkDebugCanvas.h
diff --git a/src/utils/debugger/SkDebugCanvas.h b/src/utils/debugger/SkDebugCanvas.h
index 3d9983b5046749106356e98ee760c85a4328b1d4..e1ad077f8341316bf8b6b1d70af591349faf2e69 100644
--- a/src/utils/debugger/SkDebugCanvas.h
+++ b/src/utils/debugger/SkDebugCanvas.h
@@ -35,9 +35,6 @@ public:
void setOverdrawViz(bool overdrawViz) { fOverdrawViz = overdrawViz; }
bool getOverdrawViz() const { return fOverdrawViz; }
- void setOutstandingSaveCount(int saveCount) { fOutstandingSaveCount = saveCount; }
- int getOutstandingSaveCount() const { return fOutstandingSaveCount; }
-
bool getAllowSimplifyClip() const { return fAllowSimplifyClip; }
void setPicture(SkPicture* picture) { fPicture = picture; }
@@ -137,7 +134,6 @@ public:
void setUserMatrix(SkMatrix matrix) {
fUserMatrix = matrix;
- fDrawNeedsReset = true;
}
SkString clipStackData() const { return fClipStackData; }
@@ -225,9 +221,7 @@ private:
SkPicture* fPicture;
bool fFilter;
bool fMegaVizMode;
- int fIndex;
SkMatrix fUserMatrix;
- bool fDrawNeedsReset; // fUserMatrix has changed so the incremental draw won't work
SkMatrix fMatrix;
SkIRect fClip;
@@ -242,14 +236,6 @@ private:
SkTexOverrideFilter* fTexOverrideFilter;
/**
- Number of unmatched save() calls at any point during a draw.
- If there are any saveLayer() calls outstanding, we need to resolve
- all of them, which in practice means resolving all save() calls,
- to avoid corruption of our canvas.
- */
- int fOutstandingSaveCount;
-
- /**
The active saveLayer commands at a given point in the renderering.
Only used when "mega" visualization is enabled.
*/
« no previous file with comments | « debugger/SkDebugger.cpp ('k') | src/utils/debugger/SkDebugCanvas.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698