Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 844353002: Revert of Add TestMockTimeTaskRunner in base/test. (Closed)

Created:
5 years, 11 months ago by Elliot Glaysher
Modified:
5 years, 11 months ago
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, oshima+watch_chromium.org, kalyank, erikwright+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add TestMockTimeTaskRunner in base/test. (patchset #5 id:100001 of https://codereview.chromium.org/823143004/) Reason for revert: Suspect that this patch broke the chromeos asan bots. It looks like all the AutomaticRebootManagerTestInstance/AutomaticRebootManagerTest tests now leak memory: https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/5799 Original issue's description: > Add TestMockTimeTaskRunner in base/test. > > Multiple implementations of this functionality exist with slight modifications. This CL consolidates them. > > BUG=329911 > TBR=thestig@chromium.org # For base/base.gyp changes. > > Committed: https://crrev.com/8d897fb17470c526155b2a9e86752be9a7f33c03 > Cr-Commit-Position: refs/heads/master@{#311091} TBR=bartfab@chromium.org,phajdan.jr@chromium.org,stevenjb@chromium.org,thestig@chromium.org,engedy@chromium.org NOTREECHECKS=true NOTRY=true BUG=329911 Committed: https://crrev.com/42f058496033336073d38ba0a1e36052d5b0475c Cr-Commit-Position: refs/heads/master@{#311114}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+502 lines, -462 lines) Patch
M ash/system/chromeos/session/logout_confirmation_controller_unittest.cc View 11 chunks +159 lines, -23 lines 0 comments Download
M base/base.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M base/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D base/test/test_mock_time_task_runner.h View 1 chunk +0 lines, -121 lines 0 comments Download
D base/test/test_mock_time_task_runner.cc View 1 chunk +0 lines, -157 lines 0 comments Download
M chrome/browser/chromeos/session_length_limiter_unittest.cc View 15 chunks +121 lines, -19 lines 0 comments Download
M chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc View 71 chunks +222 lines, -138 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
Created Revert of Add TestMockTimeTaskRunner in base/test.
5 years, 11 months ago (2015-01-12 21:37:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844353002/1
5 years, 11 months ago (2015-01-12 21:37:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-12 21:39:32 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 21:40:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42f058496033336073d38ba0a1e36052d5b0475c
Cr-Commit-Position: refs/heads/master@{#311114}

Powered by Google App Engine
This is Rietveld 408576698