Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 844343002: [Ozone-DRI] Add display observer (Closed)

Created:
5 years, 11 months ago by dnicoara
Modified:
5 years, 11 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-DRI] Add display observer Introduce a display change observer and make the window delegates update their cached HardwareDisplayController pointer as a result of changes in ScreenManager. BUG=446184 NOTRY=true Committed: https://crrev.com/e12b816c58657c00bec10176bdf18a6c96829258 Cr-Commit-Position: refs/heads/master@{#311112}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Update GYP #

Total comments: 2

Patch Set 4 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -27 lines) Patch
M ui/ozone/platform/dri/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A ui/ozone/platform/dri/display_change_observer.h View 1 1 chunk +26 lines, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/platform/dri/dri_window_delegate_impl.h View 1 4 chunks +14 lines, -7 lines 0 comments Download
M ui/ozone/platform/dri/dri_window_delegate_impl.cc View 4 chunks +29 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/screen_manager.h View 3 chunks +10 lines, -8 lines 0 comments Download
M ui/ozone/platform/dri/screen_manager.cc View 1 2 3 7 chunks +23 lines, -5 lines 0 comments Download
M ui/ozone/platform/dri/screen_manager_unittest.cc View 10 chunks +52 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dnicoara
PTAL
5 years, 11 months ago (2015-01-12 18:35:48 UTC) #2
alexst (slow to review)
https://codereview.chromium.org/844343002/diff/40001/ui/ozone/platform/dri/screen_manager.cc File ui/ozone/platform/dri/screen_manager.cc (right): https://codereview.chromium.org/844343002/diff/40001/ui/ozone/platform/dri/screen_manager.cc#newcode285 ui/ozone/platform/dri/screen_manager.cc:285: (*original)->AddCrtc((*mirror)->RemoveCrtc(crtc)); The expectation here is that the config is ...
5 years, 11 months ago (2015-01-12 18:49:10 UTC) #3
dnicoara
https://codereview.chromium.org/844343002/diff/40001/ui/ozone/platform/dri/screen_manager.cc File ui/ozone/platform/dri/screen_manager.cc (right): https://codereview.chromium.org/844343002/diff/40001/ui/ozone/platform/dri/screen_manager.cc#newcode285 ui/ozone/platform/dri/screen_manager.cc:285: (*original)->AddCrtc((*mirror)->RemoveCrtc(crtc)); On 2015/01/12 18:49:10, alexst wrote: > The expectation ...
5 years, 11 months ago (2015-01-12 18:57:12 UTC) #4
alexst (slow to review)
lgtm
5 years, 11 months ago (2015-01-12 19:01:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844343002/60001
5 years, 11 months ago (2015-01-12 21:23:56 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-12 21:25:21 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 21:26:39 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/e12b816c58657c00bec10176bdf18a6c96829258
Cr-Commit-Position: refs/heads/master@{#311112}

Powered by Google App Engine
This is Rietveld 408576698