MacViews: Audit TOOLKIT_VIEWS in chrome/browser/ui

MacViews: Audit TOOLKIT_VIEWS in chrome/browser/ui

When toolkit_views flips on Mac, the browser UI will still be Cocoa.

This audits the remaining TOOLKIT_VIEWS #defines under
chrome/browser/ui. Mostly constants designed for the views browser UI
that will introduce UI glitches while the Cocoa UI is still used on Mac.

For many of these the #elif defined(TOOLKIT_VIEWS) is redundant, but it
is kept as something to grep for when the browser UI eventually becomes
Views-based.

BUG=439882
Committed: https://crrev.com/e47ff58b46fff50cd8add438dda3dc98bacf7885
Cr-Commit-Position: refs/heads/master@{#311368}

[tapted, 2015-01-13 02:13:32]

tapted@chromium.org changed reviewers:
+ msw@chromium.org

[tapted, 2015-01-13 02:13:32]

Hi Michael, please take a look

[msw, 2015-01-13 20:22:24]

lgtm with one nit suggestion.

https://codereview.chromium.org/844333003/diff/1/chrome/browser/ui/autofill/c...
File chrome/browser/ui/autofill/card_unmask_prompt_view.cc (right):

https://codereview.chromium.org/844333003/diff/1/chrome/browser/ui/autofill/c...
chrome/browser/ui/autofill/card_unmask_prompt_view.cc:10: #if
!defined(OS_ANDROID) && !defined(TOOLKIT_VIEWS) || defined(OS_MACOSX)
nit: This seems specific to Mac and iOS, can we do this instead?:
#if defined(OS_MACOSX) || defined(OS_IOS)
(that seems sufficient from the list at src/build/build_config.h)

[tapted, 2015-01-13 22:17:38]

Patchset #2 (id:20001) has been deleted

[tapted, 2015-01-14 00:07:38]

https://codereview.chromium.org/844333003/diff/1/chrome/browser/ui/autofill/c...
File chrome/browser/ui/autofill/card_unmask_prompt_view.cc (right):

https://codereview.chromium.org/844333003/diff/1/chrome/browser/ui/autofill/c...
chrome/browser/ui/autofill/card_unmask_prompt_view.cc:10: #if
!defined(OS_ANDROID) && !defined(TOOLKIT_VIEWS) || defined(OS_MACOSX)
On 2015/01/13 20:22:24, msw wrote:
> nit: This seems specific to Mac and iOS, can we do this instead?:
> #if defined(OS_MACOSX) || defined(OS_IOS)
> (that seems sufficient from the list at src/build/build_config.h)

ooh - much nicer. In fact OS_IOS is only defined when OS_MACOSX already is, so
it can be just #if defined(OS_MACOSX), which is more consistent with other #ifs
under c/b/ui/autofill.

Done && checked on a bunch of builds to make sure it's all good.

[msw, 2015-01-14 00:09:13]

slgtm

https://codereview.chromium.org/844333003/diff/1/chrome/browser/ui/autofill/c...
File chrome/browser/ui/autofill/card_unmask_prompt_view.cc (right):

https://codereview.chromium.org/844333003/diff/1/chrome/browser/ui/autofill/c...
chrome/browser/ui/autofill/card_unmask_prompt_view.cc:10: #if
!defined(OS_ANDROID) && !defined(TOOLKIT_VIEWS) || defined(OS_MACOSX)
On 2015/01/14 00:07:38, tapted wrote:
> On 2015/01/13 20:22:24, msw wrote:
> > nit: This seems specific to Mac and iOS, can we do this instead?:
> > #if defined(OS_MACOSX) || defined(OS_IOS)
> > (that seems sufficient from the list at src/build/build_config.h)
> 
> ooh - much nicer. In fact OS_IOS is only defined when OS_MACOSX already is, so
> it can be just #if defined(OS_MACOSX), which is more consistent with other
#ifs
> under c/b/ui/autofill.
> 
> Done && checked on a bunch of builds to make sure it's all good.

Nice.

[tapted, 2015-01-14 00:10:26]

The CQ bit was checked by tapted@chromium.org

[commit-bot: I haz the power, 2015-01-14 00:11:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/844333003/40001

[commit-bot: I haz the power, 2015-01-14 00:13:39]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-01-14 00:16:08]

Patchset 2 (id:??) landed as
https://crrev.com/e47ff58b46fff50cd8add438dda3dc98bacf7885
Cr-Commit-Position: refs/heads/master@{#311368}