Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 844283002: Remove unused iossim setting from mac asan config (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused iossim setting from mac asan config R=glider@chromium.org LOG=n BUG=none NOTRY=true Committed: https://crrev.com/dfdc8ca12e0e7bb57572716b3047750612c41aab Cr-Commit-Position: refs/heads/master@{#26023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M build/mac/asan.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-12 08:45:40 UTC) #1
Alexander Potapenko
On 2015/01/12 08:45:40, jochen (slow) wrote: LGTM
5 years, 11 months ago (2015-01-12 08:52:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844283002/1
5 years, 11 months ago (2015-01-12 08:52:56 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-12 08:52:57 UTC) #6
Jakob Kummerow
lgtm
5 years, 11 months ago (2015-01-12 10:31:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844283002/1
5 years, 11 months ago (2015-01-12 12:25:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-12 12:25:14 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 12:25:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfdc8ca12e0e7bb57572716b3047750612c41aab
Cr-Commit-Position: refs/heads/master@{#26023}

Powered by Google App Engine
This is Rietveld 408576698