Add option to not dump childrens of a node in AX Tree.

Add option to not dump childrens of a node in AX Tree.

This would be useful in cases when on the same platform due to different version, AX tree may vary.
Please check below mentioned bug id for such kind of example.

BUG=423675
Committed: https://crrev.com/e0ee113f5020a7d514b68e1556fd7f080c232d87
Cr-Commit-Position: refs/heads/master@{#327238}

[shreeramk, 2015-01-12 17:41:05]

shreeram.k@samsung.com changed reviewers:
+ aboxhall@chromium.org, dmazzoni@chromium.org

[shreeramk, 2015-01-12 17:41:06]

Please review.

Thanks!

[dmazzoni, 2015-01-13 22:34:49]

https://codereview.chromium.org/844273002/diff/40001/content/browser/accessib...
File content/browser/accessibility/browser_accessibility.cc (right):

https://codereview.chromium.org/844273002/diff/40001/content/browser/accessib...
content/browser/accessibility/browser_accessibility.cc:54: case
ui::AX_ROLE_DATE:
Making the change here will actually make these controls inaccessible, it will
hide the important sub-controls from the platform.

Instead, we should just add a feature that allows tests to specify that children
shouldn't be dumped of a specific element.

We already have support for @NO_DUMP, which is used in tests like
button-name-calc.html and implemented in accessibility_tree_formatter.cc.

How about a new marker @NO_DUMP_CHILDREN that dumps that one node but not its
children?

[shreeramk, 2015-01-14 04:50:07]

On 2015/01/13 22:34:49, dmazzoni wrote:
>
https://codereview.chromium.org/844273002/diff/40001/content/browser/accessib...
> File content/browser/accessibility/browser_accessibility.cc (right):
> 
>
https://codereview.chromium.org/844273002/diff/40001/content/browser/accessib...
> content/browser/accessibility/browser_accessibility.cc:54: case
> ui::AX_ROLE_DATE:
> Making the change here will actually make these controls inaccessible, it will
> hide the important sub-controls from the platform.

Yeah, correct it will make the sub-controls inaccessible.

> Instead, we should just add a feature that allows tests to specify that
children
> shouldn't be dumped of a specific element.
> 
> We already have support for @NO_DUMP, which is used in tests like
> button-name-calc.html and implemented in accessibility_tree_formatter.cc.
> 
> How about a new marker @NO_DUMP_CHILDREN that dumps that one node but not its
> children?]

Yeah better to add a new marker to not dump childrens.

[shreeramk, 2015-04-27 14:28:59]

Please review the changes. 
I'll update the expectations in next patchset.

Thanks.

[dmazzoni, 2015-04-27 19:56:22]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2015-04-27 19:56:23]

lgtm

Fantastic, thanks.

[commit-bot: I haz the power, 2015-04-27 19:57:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/844273002/80001

[commit-bot: I haz the power, 2015-04-27 21:12:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-27 21:12:36]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[shreeramk, 2015-04-28 04:29:16]

The CQ bit was checked by shreeram.k@samsung.com

[shreeramk, 2015-04-28 04:29:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/844273002/#ps100001
(title: "updating expectations")

[commit-bot: I haz the power, 2015-04-28 04:29:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/844273002/100001

[commit-bot: I haz the power, 2015-04-28 06:32:58]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-04-28 06:33:51]

Patchset 6 (id:??) landed as
https://crrev.com/e0ee113f5020a7d514b68e1556fd7f080c232d87
Cr-Commit-Position: refs/heads/master@{#327238}