Issue 844193009: Change background-repeat default to no-repeat

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 844193009: Change background-repeat default to no-repeat (Closed)

Created:
5 years, 11 months ago by abarth-chromium

Modified:
5 years, 11 months ago

Reviewers:
esprehn

CC:
esprehn, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Change background-repeat default to no-repeat Previously, if you had a generated background image and a translucent (or rounded) border, we would draw the image nine times because we would inflate the fill rect to draw behind the border. With no-repeat, we only draw the image once. This saves 4.5% of record time on flights-app. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/087ca0eae6699cf4f4c61c8b35a558ecfbef6897

Patch Set 1 #

Patch Set 2 : now with test results #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
M	sky/engine/core/rendering/style/FillLayer.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/examples/flights-app/app-toast.sky	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/tests/framework/flights-app-expected.txt	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/tests/framework/flights-app-pixels-expected.sky	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

5 years, 11 months ago (2015-01-22 00:42:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
087ca0eae6699cf4f4c61c8b35a558ecfbef6897 (presubmit successful).

Expand Messages | Collapse Messages