tools/metrics/histograms/histograms.xml - Issue 844193005: Add UMA metrics for profile switching.

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 844193005: Add UMA metrics for profile switching. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use existing histogram and fix issues raised by mlerman@ Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 30eb8601fe704b80fd48da67f8d28d09fcd62d2a..92e89668988ff37e8885c5567b5a0f9de3780ed6 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -27857,6 +27857,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="Profile.NumberOfSwitches">

+ <owner>anthonyvd@chromium.org</owner>

+ <summary>

+ Counts the number of times profiles were switched in a browser session. This

+ value is incremented when a profile is switched to and the result is logged

+ during shutdown.

+ </summary>

+</histogram>

<owner>mlerman@chromium.org</owner>

@@ -62089,6 +62098,17 @@ To add a new entry, add it with any value and run test to compute valid value.

<affected-histogram name="Profile.DesktopMenu"/>

</histogram_suffixes>

+<histogram_suffixes name="ProfileOpenState" separator=".">

+ <suffix name="ToOpenedProfile"

+ label="The profile being switched to was already opened"/>

Mike Lerman 2015/01/23 19:46:14 I'd explicitly say "The profile being switched to

anthonyvd 2015/01/26 16:07:48 Done.

+ <suffix name="ToUnopenedProfile"

+ label="The profile being switched to wasn't already opened"/>

Mike Lerman 2015/01/23 19:46:14 A lot of people confuse what a profile being open

anthonyvd 2015/01/26 16:07:48 Done.

+ <suffix name="ToOpenedProfileWithoutBrowser"

+ label="The profile being switched to was already opened and had no

+ active browsers"/>

+ <affected-histogram name="Profile.OpenMethod"/>

anthonyvd 2015/01/21 23:31:19 jwd@ can you confirm if suffixing an existing hist

jwd 2015/01/22 21:11:33 Yes, that should be fine.

+</histogram_suffixes>

<histogram_suffixes name="ProfilePictureDownload" separator=".">