Add UMA metrics for profile switching.

chrome/browser/profiles/profile_metrics.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_metrics.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_info_cache.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/signin/signin_header_helper.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_iterator.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/installer/util/google_update_settings.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/user_metrics.h"
 
 namespace {
 
 const int kMaximumReportedProfileCount = 5;
 const int kMaximumDaysOfDisuse = 4 * 7;  // Should be integral number of weeks.
 
+size_t number_of_profile_switches_ = 0;
+
 ProfileMetrics::ProfileType GetProfileType(
     const base::FilePath& profile_path) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   ProfileMetrics::ProfileType metric = ProfileMetrics::SECONDARY;
   ProfileManager* manager = g_browser_process->profile_manager();
   base::FilePath user_data_dir;
   // In unittests, we do not always have a profile_manager so check.
   if (manager) {
     user_data_dir = manager->user_data_dir();
   }
@@ skipping 105 matching lines @@
         if (info_cache.IsUsingGAIAPictureOfProfileAtIndex(i))
           counts->gaia_icon++;
         if (info_cache.ProfileIsAuthErrorAtIndex(i))
           counts->auth_errors++;
       }
     }
   }
   return true;
 }
 
+ProfileMetrics::ProfileOpenState ProfileMetrics::GetProfileOpenState(
+    ProfileManager* manager,
+    const base::FilePath& path) {
+  Profile* profile_switched_to = manager->GetProfileByPath(path);
+  ProfileMetrics::ProfileOpenState profile_open_state = PROFILE_UNOPENED;
+
+  if (profile_switched_to) {
+    profile_open_state = PROFILE_OPENED_NO_BROWSER;
+    for (chrome::BrowserIterator it; !it.done(); it.Next()) {
+      if (it->profile()->GetOriginalProfile() ==
+          profile_switched_to->GetOriginalProfile()) {
+        profile_open_state = PROFILE_OPENED;

[Mike Lerman, 2015/01/23 19:46:14]

Perhaps you can just return PROFILE_OPENED; no need to create a local
ProfileOpenState instance?

[anthonyvd, 2015/01/26 16:07:48]

Done.

+        break;
+      }
+    }
+  }
+  return profile_open_state;

[Mike Lerman, 2015/01/23 19:46:14]

Flip your condition around, and return early. So what I'd so is:

Profile* switched_to = manager->GetProfileByPath()
// If the ProfileManager doesn't know the Profile, it's never been opened.
if (null) return PROFILE_UNOPENED;

<rest of function>
...

[anthonyvd, 2015/01/26 16:07:48]

Done.

+}
 
 void ProfileMetrics::UpdateReportedProfilesStatistics(ProfileManager* manager) {
   ProfileCounts counts;
   if (CountProfileInformation(manager, &counts)) {
     int limited_total = counts.total;
     int limited_signedin = counts.signedin;
     if (limited_total > kMaximumReportedProfileCount) {
       limited_total = kMaximumReportedProfileCount + 1;
       limited_signedin =
           (int)((float)(counts.signedin * limited_total)
           / counts.total + 0.5);
     }
     UpdateReportedOSProfileStatistics(limited_total, limited_signedin);
   }
 }
 
+void ProfileMetrics::LogNumberOfProfileSwitches() {
+  UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfSwitches",
+                           number_of_profile_switches_);
+}
+
 void ProfileMetrics::LogNumberOfProfiles(ProfileManager* manager) {
   ProfileCounts counts;
   bool success = CountProfileInformation(manager, &counts);
   UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfProfiles", counts.total);
 
   // Ignore other metrics if we have no profiles, e.g. in Chrome Frame tests.
   if (success) {
     UMA_HISTOGRAM_COUNTS_100("Profile.NumberOfManagedProfiles",
                              counts.supervised);
     UMA_HISTOGRAM_COUNTS_100("Profile.PercentageOfManagedProfiles",
@@ skipping 123 matching lines @@
   UMA_HISTOGRAM_ENUMERATION("Profile.NetUserCount", PROFILE_DELETED,
                             NUM_PROFILE_NET_METRICS);
 }
 
 void ProfileMetrics::LogProfileOpenMethod(ProfileOpen metric) {
   DCHECK(metric < NUM_PROFILE_OPEN_METRICS);
   UMA_HISTOGRAM_ENUMERATION("Profile.OpenMethod", metric,
                             NUM_PROFILE_OPEN_METRICS);
 }
 
+void ProfileMetrics::LogProfileSwitch(
+    ProfileOpen metric,
+    ProfileManager* manager,
+    const base::FilePath& profile_path) {
+  DCHECK(metric < NUM_PROFILE_OPEN_METRICS);
+  ProfileOpenState open_state = GetProfileOpenState(manager, profile_path);
+  switch (open_state) {
+    case PROFILE_OPENED:
+      UMA_HISTOGRAM_ENUMERATION(
+        "Profile.OpenMethod.ToOpenedProfile",
+        metric,
+        NUM_PROFILE_OPEN_METRICS);
+      break;
+    case PROFILE_OPENED_NO_BROWSER:
+      UMA_HISTOGRAM_ENUMERATION(
+        "Profile.OpenMethod.ToOpenedProfileWithoutBrowser",
+        metric,
+        NUM_PROFILE_OPEN_METRICS);
+      break;
+    case PROFILE_UNOPENED:
+      UMA_HISTOGRAM_ENUMERATION(
+        "Profile.OpenMethod.ToUnopenedProfile",
+        metric,
+        NUM_PROFILE_OPEN_METRICS);
+      break;
+    default:
+      // There are no other possible values.
+      NOTREACHED();
+      break;
+  }
+
+  ++number_of_profile_switches_;
+  // The LogOpenMethod histogram aggregates data from profile switches as well
+  // as opening of profile related UI elements.
+  LogProfileOpenMethod(metric);
+}
+
 void ProfileMetrics::LogProfileSwitchGaia(ProfileGaia metric) {
   if (metric == GAIA_OPT_IN)
     LogProfileAvatarSelection(AVATAR_GAIA);
   UMA_HISTOGRAM_ENUMERATION("Profile.SwitchGaiaPhotoSettings",
                             metric,
                             NUM_PROFILE_GAIA_METRICS);
 }
 
-void ProfileMetrics::LogProfileSwitchUser(ProfileOpen metric) {
-  DCHECK(metric < NUM_PROFILE_OPEN_METRICS);
-  UMA_HISTOGRAM_ENUMERATION("Profile.OpenMethod", metric,
-                            NUM_PROFILE_OPEN_METRICS);
-}
-
 void ProfileMetrics::LogProfileSyncInfo(ProfileSync metric) {
   DCHECK(metric < NUM_PROFILE_SYNC_METRICS);
   UMA_HISTOGRAM_ENUMERATION("Profile.SyncCustomize", metric,
                             NUM_PROFILE_SYNC_METRICS);
 }
 
 void ProfileMetrics::LogProfileAuthResult(ProfileAuth metric) {
   UMA_HISTOGRAM_ENUMERATION("Profile.AuthResult", metric,
                             NUM_PROFILE_AUTH_METRICS);
 }
@@ skipping 131 matching lines @@
   UMA_HISTOGRAM_ENUMERATION("Profile.SyncSignIn",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }
 
 void ProfileMetrics::LogProfileUpdate(const base::FilePath& profile_path) {
   UMA_HISTOGRAM_ENUMERATION("Profile.Update",
                             GetProfileType(profile_path),
                             NUM_PROFILE_TYPE_METRICS);
 }