Add UMA metrics for profile switching.

chrome/browser/profiles/profile_window.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_window.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 252 matching lines @@
   browser_creator.LaunchBrowser(command_line, profile, base::FilePath(),
                                 process_startup, is_first_run, &return_code);
 #endif  // defined(OS_IOS)
 }
 
 void SwitchToProfile(const base::FilePath& path,
                      chrome::HostDesktopType desktop_type,
                      bool always_create,
                      ProfileManager::CreateCallback callback,
                      ProfileMetrics::ProfileOpen metric) {
+  bool already_opened =
+      g_browser_process->profile_manager()->GetProfileByPath(path) != NULL;

[Mike Lerman, 2015/01/21 20:58:03]

Once a profile has been opened by the ProfileManager, the object stays in memory
for the lifetime of the Chrome Process, even if all the browser windows are
closed. However, we're interested in the user workflows - so if a Profile's been
loaded once but all browsers are currently closed, that's interesting and
distinct from the scenario where a Profile's been loaded and there's at least
one browser open. I'd track each state separately: Profile's not yet loaded,
Profile's been loaded and there are no browsers open, Profile's been loaded and
there are browsers open.

For a hint on counting browsers:  BrowserList::CloseAllBrowsersWithProfile()

[anthonyvd, 2015/01/23 16:01:31]

Done.

+  ProfileMetrics::LogProfileSwitch(metric, already_opened);
   g_browser_process->profile_manager()->CreateProfileAsync(
       path,
       base::Bind(&OpenBrowserWindowForProfile,
                  callback,
                  always_create,
                  false,
                  desktop_type),
       base::string16(),
       base::string16(),
       std::string());
-  ProfileMetrics::LogProfileSwitchUser(metric);
 }
 
 void SwitchToGuestProfile(chrome::HostDesktopType desktop_type,
                           ProfileManager::CreateCallback callback) {
+  base::FilePath path = ProfileManager::GetGuestProfilePath();

[Mike Lerman, 2015/01/21 20:58:03]

const base::FilePath&

[anthonyvd, 2015/01/23 16:01:31]

Done.

+  bool already_opened =
+      g_browser_process->profile_manager()->GetProfileByPath(path) != NULL;

[Mike Lerman, 2015/01/21 20:58:03]

(Same as above)

[anthonyvd, 2015/01/23 16:01:31]

Done.

+
+  ProfileMetrics::LogProfileSwitch(ProfileMetrics::SWITCH_PROFILE_GUEST,
+                                   already_opened);
   g_browser_process->profile_manager()->CreateProfileAsync(
-      ProfileManager::GetGuestProfilePath(),
+      path,
       base::Bind(&OpenBrowserWindowForProfile,
                  callback,
                  false,
                  false,
                  desktop_type),
       base::string16(),
       base::string16(),
       std::string());
-  ProfileMetrics::LogProfileSwitchUser(ProfileMetrics::SWITCH_PROFILE_GUEST);
 }
 
 void CreateAndSwitchToNewProfile(chrome::HostDesktopType desktop_type,
                                  ProfileManager::CreateCallback callback,
                                  ProfileMetrics::ProfileAdd metric) {
   ProfileInfoCache& cache =
       g_browser_process->profile_manager()->GetProfileInfoCache();
 
   int placeholder_avatar_index = profiles::GetPlaceholderAvatarIndex();
   ProfileManager::CreateMultiProfileAsync(
@@ skipping 190 matching lines @@
     case BrowserWindow::AVATAR_BUBBLE_MODE_SHOW_ERROR:
       *bubble_view_mode = BUBBLE_VIEW_MODE_PROFILE_CHOOSER;
       *tutorial_mode = TUTORIAL_MODE_SHOW_ERROR;
       return;
     default:
       *bubble_view_mode = profiles::BUBBLE_VIEW_MODE_PROFILE_CHOOSER;
   }
 }
 
 }  // namespace profiles