Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Unified Diff: src/accessors.cc

Issue 844193004: Correctly load RegExp.source from the holder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/accessors.cc
diff --git a/src/accessors.cc b/src/accessors.cc
index 6b7ec058d93c59bfda56bf936dba56b5fcee9ecc..662a9e126b04b1bad9489ddb468c09666436eff1 100644
--- a/src/accessors.cc
+++ b/src/accessors.cc
@@ -382,9 +382,9 @@ void Accessors::RegExpSourceGetter(
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(info.GetIsolate());
HandleScope scope(isolate);
- Handle<Object> receiver =
- Utils::OpenHandle(*v8::Local<v8::Value>(info.This()));
- Handle<JSRegExp> regexp = Handle<JSRegExp>::cast(receiver);
+ Handle<Object> holder =
+ Utils::OpenHandle(*v8::Local<v8::Value>(info.Holder()));
+ Handle<JSRegExp> regexp = Handle<JSRegExp>::cast(holder);
Handle<String> result;
if (regexp->TypeTag() == JSRegExp::NOT_COMPILED) {
result = isolate->factory()->empty_string();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698