Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 844193004: Correctly load RegExp.source from the holder. (Closed)

Created:
5 years, 11 months ago by Yang
Modified:
5 years, 11 months ago
Reviewers:
mvstanton
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly load RegExp.source from the holder. R=mvstanton@chromium.org BUG=chromium:447561 LOG=N Committed: https://crrev.com/3a53f2fda376f5f5a2fb723200f50a65dbe43664 Cr-Commit-Position: refs/heads/master@{#26125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/accessors.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 11 months ago (2015-01-19 08:14:39 UTC) #1
mvstanton
lgtm
5 years, 11 months ago (2015-01-19 08:16:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844193004/1
5 years, 11 months ago (2015-01-19 08:18:05 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24)
5 years, 11 months ago (2015-01-19 08:22:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844193004/1
5 years, 11 months ago (2015-01-19 08:28:05 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-19 09:17:20 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-19 09:17:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3a53f2fda376f5f5a2fb723200f50a65dbe43664
Cr-Commit-Position: refs/heads/master@{#26125}

Powered by Google App Engine
This is Rietveld 408576698