Issue 844133002: Simplify tree scope tracking in StyleEngine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 844133002: Simplify tree scope tracking in StyleEngine. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
ojan

CC:
ojan, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Simplify tree scope tracking in StyleEngine. ShadowRoot should deal with adding and removing itself from the active scope list. HTMLStyleElement should just add/remove itself directy from the StyleSheetCollection on the scope its entering or leaving in insertedInto/removedFrom. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8e6484592e6ff253739cfa0e625fb6ccab4c3635

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -77 lines)			Patch
M	sky/engine/core/dom/StyleEngine.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/engine/core/dom/StyleEngine.cpp	View	3 chunks	+7 lines, -36 lines	0 comments	Download
M	sky/engine/core/dom/StyleSheetCollection.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/engine/core/dom/StyleSheetCollection.cpp	View	1 chunk	+7 lines, -17 lines	0 comments	Download
M	sky/engine/core/dom/shadow/ShadowRoot.cpp	View	3 chunks	+7 lines, -0 lines	0 comments	Download
M	sky/engine/core/html/HTMLStyleElement.cpp	View	4 chunks	+6 lines, -19 lines	0 comments	Download

Total messages: 3 (0 generated)

esprehn

5 years, 11 months ago (2015-01-10 04:12:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
8e6484592e6ff253739cfa0e625fb6ccab4c3635 (presubmit successful).