ui/gfx/font_list_unittest.cc - Issue 844083002: Get all font unittests running with DirectWrite on Windows 7+

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/font_list_unittest.cc

Issue 844083002: Get all font unittests running with DirectWrite on Windows 7+ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/font_list_unittest.cc

diff --git a/ui/gfx/font_list_unittest.cc b/ui/gfx/font_list_unittest.cc

index 6dcbb855d083d4483fb3e85e110cad02714fe174..6cae7c4e92ab6cd06aaff1c81c9041efc13cbc4d 100644

--- a/ui/gfx/font_list_unittest.cc

+++ b/ui/gfx/font_list_unittest.cc

@@ -271,8 +271,7 @@ TEST(FontListTest, Fonts_GetHeight_GetBaseline) {

ASSERT_EQ("symbol",

base::StringToLowerASCII(font2.GetActualFontNameForTesting()));

EXPECT_NE(font1.GetBaseline(), font2.GetBaseline());

- EXPECT_NE(font1.GetHeight() - font1.GetBaseline(),

- font2.GetHeight() - font2.GetBaseline());

+ EXPECT_NE(font1.GetHeight(), font2.GetHeight());

std::vector<Font> fonts;

fonts.push_back(font1);

fonts.push_back(font2);

« no previous file with comments | « no previous file | ui/gfx/platform_font_win.cc » ('j') | ui/gfx/platform_font_win_unittest.cc » ('J')