Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 844073002: Make changes to the NaCl demos in prep for integrating them into developer.chrome.com: (Closed)

Created:
5 years, 11 months ago by jpmedley
Modified:
5 years, 11 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make changes to the NaCl demos in prep for integrating them into developer.chrome.com: * Style changes to make the content look more like said site. * Change the path to the css file to match said site so that pages may be duplicated with changing them. BUG= Committed: https://crrev.com/57691de83022b6acc4ba89a5366082972323b4cd Cr-Commit-Position: refs/heads/master@{#311322}

Patch Set 1 #

Patch Set 2 : Added a README file explaining why the stylesheet was moved. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -403 lines) Patch
A native_client_sdk/src/gonacl_appengine/static/README View 1 1 chunk +3 lines, -0 lines 0 comments Download
M native_client_sdk/src/gonacl_appengine/static/bullet/index.html View 1 chunk +1 line, -1 line 0 comments Download
A + native_client_sdk/src/gonacl_appengine/static/css/out/icons.png View Binary file 0 comments Download
A + native_client_sdk/src/gonacl_appengine/static/css/out/robot.png View Binary file 0 comments Download
A + native_client_sdk/src/gonacl_appengine/static/css/out/site.css View 4 chunks +4 lines, -4 lines 0 comments Download
A + native_client_sdk/src/gonacl_appengine/static/css/out/wrench.png View Binary file 0 comments Download
M native_client_sdk/src/gonacl_appengine/static/cube/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/static/earth/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/static/home/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/static/index.html View 1 chunk +2 lines, -2 lines 0 comments Download
M native_client_sdk/src/gonacl_appengine/static/life/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/static/lua/index.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/src/gonacl_appengine/static/smoothlife/index.html View 1 chunk +1 line, -1 line 0 comments Download
D native_client_sdk/src/gonacl_appengine/static/styles/icons.png View Binary file 0 comments Download
D native_client_sdk/src/gonacl_appengine/static/styles/robot.png View Binary file 0 comments Download
D native_client_sdk/src/gonacl_appengine/static/styles/style.css View 1 chunk +0 lines, -389 lines 0 comments Download
D native_client_sdk/src/gonacl_appengine/static/styles/wrench.png View Binary file 0 comments Download
M native_client_sdk/src/gonacl_appengine/static/voronoi/index.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
jpmedley
Here's the first preparatory change. More to come.
5 years, 11 months ago (2015-01-09 22:47:24 UTC) #2
binji
On 2015/01/09 22:47:24, jpmedley wrote: > Here's the first preparatory change. More to come. This ...
5 years, 11 months ago (2015-01-09 23:12:07 UTC) #3
jpmedley
ptal
5 years, 11 months ago (2015-01-09 23:31:16 UTC) #4
binji
thanks, lgtm
5 years, 11 months ago (2015-01-12 20:12:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/844073002/20001
5 years, 11 months ago (2015-01-13 19:33:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-13 20:57:53 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 21:00:10 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57691de83022b6acc4ba89a5366082972323b4cd
Cr-Commit-Position: refs/heads/master@{#311322}

Powered by Google App Engine
This is Rietveld 408576698