Issue 8440008: Add traces in compositor, views and skia

Issue 8440008: Add traces in compositor, views and skia (Closed)

Created:
9 years, 1 month ago by piman

Modified:
9 years, 1 month ago

Reviewers:
Nico, sky, (unused - use chromium)

CC:
chromium-reviews, Ian Vollick, piman+watch_chromium.org, dhollowa, tfarina, jonathan.backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Add traces in compositor, views and skia BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108174

Patch Set 2 : git try #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -4 lines)			Patch
M	skia/ext/platform_canvas_linux.cc	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	skia/ext/platform_canvas_mac.cc	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download
M	skia/ext/platform_canvas_win.cc	View	1	3 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/gfx/compositor/compositor_gl.cc	View		5 chunks	+5 lines, -0 lines	0 comments	Download
M	ui/gfx/compositor/layer.cc	View		4 chunks	+4 lines, -0 lines	0 comments	Download
M	views/view.cc	View		2 chunks	+18 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

(unused - use chromium)

skia bits lgtm, but they'd look even better if you did the same changes for ...

9 years, 1 month ago (2011-11-01 18:47:54 UTC) #3

piman

http://codereview.chromium.org/8440008/diff/1/skia/ext/platform_canvas_linux.cc File skia/ext/platform_canvas_linux.cc (right): http://codereview.chromium.org/8440008/diff/1/skia/ext/platform_canvas_linux.cc#newcode15 skia/ext/platform_canvas_linux.cc:15: TRACE_EVENT2("skia", "PlatformCanvas::PlatformCanvas", On 2011/11/01 18:47:55, thakis wrote: > For ...

9 years, 1 month ago (2011-11-01 19:19:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8440008/4001

9 years, 1 month ago (2011-11-01 20:13:39 UTC) #5

Change committed as 108174

Expand Messages | Collapse Messages