Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 843973002: Correctly setup the freelist of the coderange on Win64 (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Correctly setup the freelist of the coderange on Win64 Since we have a special guard page at the beginning of the code range on win64, we need to make sure to adjust the size of the free list accordingly when creating it. BUG=chromium:447555 R=hpayer@chromium.org LOG=y Committed: https://crrev.com/21ce2464232e6496408bb90a291a0fbd87b1baf7 Cr-Commit-Position: refs/heads/master@{#26012}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/heap/spaces.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/cctest/test-alloc.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-09 12:35:39 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 11 months ago (2015-01-09 12:45:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843973002/20001
5 years, 11 months ago (2015-01-09 12:48:11 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-09 13:07:34 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 13:07:52 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/21ce2464232e6496408bb90a291a0fbd87b1baf7
Cr-Commit-Position: refs/heads/master@{#26012}

Powered by Google App Engine
This is Rietveld 408576698