Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 843953003: Fixed testExecuteScriptIsAbortedWhenWebViewSourceIsChanged raciness. (Closed)

Created:
5 years, 11 months ago by Fady Samuel
Modified:
5 years, 11 months ago
Reviewers:
Xi Han
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed testExecuteScriptIsAbortedWhenWebViewSourceIsChanged raciness. BUG=none Committed: https://crrev.com/4ada10ec7482f0116a76d7b5378d90bbf2c93fb8 Cr-Commit-Position: refs/heads/master@{#311785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -46 lines) Patch
M chrome/test/data/extensions/platform_apps/web_view/shim/main.js View 1 chunk +30 lines, -23 lines 0 comments Download
M extensions/test/data/web_view/apitest/main.js View 1 chunk +30 lines, -23 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Fady Samuel
5 years, 11 months ago (2015-01-15 20:22:17 UTC) #2
Xi Han
lgtm
5 years, 11 months ago (2015-01-15 20:31:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843953003/1
5 years, 11 months ago (2015-01-15 20:32:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/45711)
5 years, 11 months ago (2015-01-15 22:52:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843953003/1
5 years, 11 months ago (2015-01-15 22:56:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-16 00:42:17 UTC) #10
commit-bot: I haz the power
5 years, 11 months ago (2015-01-16 00:44:34 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4ada10ec7482f0116a76d7b5378d90bbf2c93fb8
Cr-Commit-Position: refs/heads/master@{#311785}

Powered by Google App Engine
This is Rietveld 408576698