Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: trunk/src/media/video/capture/video_capture_types.h

Issue 84393002: Revert 236927 "Reorganize media::VideoCapture* types" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/media/video/capture/video_capture_types.h
===================================================================
--- trunk/src/media/video/capture/video_capture_types.h (revision 236934)
+++ trunk/src/media/video/capture/video_capture_types.h (working copy)
@@ -5,17 +5,20 @@
#ifndef MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_TYPES_H_
#define MEDIA_VIDEO_CAPTURE_VIDEO_CAPTURE_TYPES_H_
-#include <vector>
+#include "media/base/video_frame.h"
-#include "media/base/media_export.h"
-#include "ui/gfx/size.h"
-
namespace media {
// TODO(wjia): this type should be defined in a common place and
// shared with device manager.
typedef int VideoCaptureSessionId;
+enum VideoCaptureResolutionType {
+ ConstantResolutionVideoCaptureDevice = 0,
+ VariableResolutionVideoCaptureDevice,
+ MaxVideoCaptureResolutionType, // Must be last.
+};
+
// Color formats from camera.
enum VideoPixelFormat {
PIXEL_FORMAT_UNKNOWN, // Color format not set.
@@ -27,52 +30,49 @@
PIXEL_FORMAT_MJPEG,
PIXEL_FORMAT_NV21,
PIXEL_FORMAT_YV12,
- PIXEL_FORMAT_MAX,
};
// Video capture format specification.
-// This class is used by the video capture device to specify the format of every
-// frame captured and returned to a client.
class MEDIA_EXPORT VideoCaptureFormat {
public:
VideoCaptureFormat();
- VideoCaptureFormat(const gfx::Size& frame_size,
+ VideoCaptureFormat(int width,
+ int height,
int frame_rate,
- VideoPixelFormat pixel_format);
+ VideoCaptureResolutionType frame_size_type);
// Checks that all values are in the expected range. All limits are specified
// in media::Limits.
bool IsValid() const;
- gfx::Size frame_size;
+ int width;
+ int height;
int frame_rate;
- VideoPixelFormat pixel_format;
+ VideoCaptureResolutionType frame_size_type;
};
// Parameters for starting video capture.
-// This class is used by the client of a video capture device to specify the
-// format of frames in which the client would like to have captured frames
-// returned.
class MEDIA_EXPORT VideoCaptureParams {
public:
VideoCaptureParams();
+ // Identifies which device is to be started.
+ VideoCaptureSessionId session_id;
// Requests a resolution and format at which the capture will occur.
VideoCaptureFormat requested_format;
-
- // Allow mid-capture resolution change.
- bool allow_resolution_change;
};
// Capabilities describe the format a camera captures video in.
-// This class is used by the video capture device to report the formats in which
-// it is capable of capturing frames.
-class MEDIA_EXPORT VideoCaptureCapability {
+class MEDIA_EXPORT VideoCaptureCapability : public VideoCaptureFormat {
public:
VideoCaptureCapability();
+ VideoCaptureCapability(int width,
+ int height,
+ int frame_rate,
+ VideoPixelFormat color,
+ VideoCaptureResolutionType frame_size_type);
- // Supported resolution and format.
- VideoCaptureFormat supported_format;
+ VideoPixelFormat color; // Desired video type.
};
typedef std::vector<VideoCaptureCapability> VideoCaptureCapabilities;
« no previous file with comments | « trunk/src/media/video/capture/video_capture_proxy.cc ('k') | trunk/src/media/video/capture/video_capture_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698