Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Unified Diff: trunk/src/content/browser/renderer_host/media/video_capture_host.cc

Issue 84393002: Revert 236927 "Reorganize media::VideoCapture* types" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/content/browser/renderer_host/media/video_capture_host.cc
===================================================================
--- trunk/src/content/browser/renderer_host/media/video_capture_host.cc (revision 236934)
+++ trunk/src/content/browser/renderer_host/media/video_capture_host.cc (working copy)
@@ -164,43 +164,36 @@
}
void VideoCaptureHost::OnStartCapture(int device_id,
- media::VideoCaptureSessionId session_id,
const media::VideoCaptureParams& params) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
- DVLOG(1) << "VideoCaptureHost::OnStartCapture:"
- << " session_id=" << session_id
- << ", device_id=" << device_id
- << ", format=" << params.requested_format.frame_size.ToString()
- << "@" << params.requested_format.frame_rate
- << " (" << (params.allow_resolution_change ? "variable" : "constant")
+ DVLOG(1) << "VideoCaptureHost::OnStartCapture, device_id " << device_id
+ << ", (" << params.requested_format.width
+ << ", " << params.requested_format.height
+ << ", " << params.requested_format.frame_rate
+ << ", " << params.session_id << ", variable resolution device:"
+ << ((params.requested_format.frame_size_type ==
+ media::VariableResolutionVideoCaptureDevice) ? "yes" : "no")
<< ")";
VideoCaptureControllerID controller_id(device_id);
DCHECK(entries_.find(controller_id) == entries_.end());
entries_[controller_id] = base::WeakPtr<VideoCaptureController>();
media_stream_manager_->video_capture_manager()->StartCaptureForClient(
- session_id,
- params,
- PeerHandle(),
- controller_id,
- this,
- base::Bind(&VideoCaptureHost::OnControllerAdded, this, device_id));
+ params, PeerHandle(), controller_id, this, base::Bind(
+ &VideoCaptureHost::OnControllerAdded, this, device_id, params));
}
void VideoCaptureHost::OnControllerAdded(
- int device_id,
+ int device_id, const media::VideoCaptureParams& params,
const base::WeakPtr<VideoCaptureController>& controller) {
BrowserThread::PostTask(
- BrowserThread::IO,
- FROM_HERE,
+ BrowserThread::IO, FROM_HERE,
base::Bind(&VideoCaptureHost::DoControllerAddedOnIOThread,
- this,
- device_id,
- controller));
+ this, device_id, params, controller));
}
void VideoCaptureHost::DoControllerAddedOnIOThread(
- int device_id,
+ int device_id, const media::VideoCaptureParams& params,
const base::WeakPtr<VideoCaptureController>& controller) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
VideoCaptureControllerID controller_id(device_id);

Powered by Google App Engine
This is Rietveld 408576698