Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 843923002: Revert of Add print and getSelectedText functions to the OOP PDF scripting API (Closed)

Created:
5 years, 11 months ago by keishi
Modified:
5 years, 11 months ago
Reviewers:
Sam McNally, raymes
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@postMessage-api
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add print and getSelectedText functions to the OOP PDF scripting API (patchset #3 id:40001 of https://codereview.chromium.org/843463002/) Reason for revert: Win7 Tests fail the test PDFExtensionTest.BasicPlugin. API Test Error in testGetSelectedText http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/7823/steps/browser_tests/logs/BasicPlugin Original issue's description: > Add print and getSelectedText functions to the OOP PDF scripting API > > These are needed by some internal users (see the bug for more details). > A test is added for selectAll/getSelectedText. > > BUG=415858 > > Committed: https://crrev.com/7b1df224a957da8376e0ae71ab2d53dabf658b0a > Cr-Commit-Position: refs/heads/master@{#310663} TBR=sammc@chromium.org,raymes@chromium.org NOTREECHECKS=true NOTRY=true BUG=415858 Committed: https://crrev.com/39de3f06b6b69bd409c7f261ef63e2ad24df1e3a Cr-Commit-Position: refs/heads/master@{#310716}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -69 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_scripting_api.js View 3 chunks +1 line, -44 lines 0 comments Download
M chrome/test/data/pdf/basic_plugin_test.js View 1 chunk +1 line, -9 lines 0 comments Download
M pdf/out_of_process_instance.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
keishi
Created Revert of Add print and getSelectedText functions to the OOP PDF scripting API
5 years, 11 months ago (2015-01-09 05:56:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843923002/1
5 years, 11 months ago (2015-01-09 05:57:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 05:58:29 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 05:59:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39de3f06b6b69bd409c7f261ef63e2ad24df1e3a
Cr-Commit-Position: refs/heads/master@{#310716}

Powered by Google App Engine
This is Rietveld 408576698