Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: BUILD.gn

Issue 843913009: Reland Auto-generate v8 version based on tags. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gitignore ('k') | DEPS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index a524ba10a3e7a1cfa792952756940263118c8031..6822f30ab306419c36f1981b85956bc4c47824a9 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -314,6 +314,25 @@ action("run_mksnapshot") {
}
}
+action("generate_v8_version") {
+ visibility = [ ":*" ] # Only targets in this file can depend on this.
+
+ script = "tools/push-to-trunk/generate_version.py"
+
+ sources = [
+ "src/version.cc",
+ ]
+
+ outputs = [
+ "$target_gen_dir/version.cc"
+ ]
+
+ args = [
+ rebase_path("$target_gen_dir/version.cc", root_build_dir),
+ ]
+}
+
+
###############################################################################
# Source Sets (aka static libraries)
#
@@ -398,6 +417,7 @@ source_set("v8_base") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
sources = [
+ "$target_gen_dir/version.cc",
"src/accessors.cc",
"src/accessors.h",
"src/allocation.cc",
@@ -933,7 +953,6 @@ source_set("v8_base") {
"src/v8threads.h",
"src/variables.cc",
"src/variables.h",
- "src/version.cc",
"src/version.h",
"src/vm-state-inl.h",
"src/vm-state.h",
@@ -1211,6 +1230,7 @@ source_set("v8_base") {
defines = []
deps = [
":v8_libbase",
+ ":generate_v8_version",
]
if (is_win) {
« no previous file with comments | « .gitignore ('k') | DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698