content/shell/android/java/src/org/chromium/content_shell/ShellManager.java - Issue 843883002: [Android] Fix a flicker in stopping Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/java/src/org/chromium/content_shell/ShellManager.java

Issue 843883002: [Android] Fix a flicker in stopping Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added 'onActivityStop()' back in order not to break downstream Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java ('k') | content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/java/src/org/chromium/content_shell/ShellManager.java

diff --git a/content/shell/android/java/src/org/chromium/content_shell/ShellManager.java b/content/shell/android/java/src/org/chromium/content_shell/ShellManager.java

index 1dfc60a632494ad504ec9d34e4f5f0987841f1ea..e4194db500ef7b97c716d4027701e00abe51a959 100644

--- a/content/shell/android/java/src/org/chromium/content_shell/ShellManager.java

+++ b/content/shell/android/java/src/org/chromium/content_shell/ShellManager.java

@@ -78,6 +78,15 @@ public class ShellManager extends FrameLayout {

sStartup = false;

}

+ @Override

+ protected void onWindowVisibilityChanged(int visibility) {

+ if (visibility == View.GONE && mActiveShell != null) {

+ ContentViewCore contentViewCore = mActiveShell.getContentViewCore();

+ if (contentViewCore != null) contentViewCore.onHide();

+ }

+ super.onWindowVisibilityChanged(visibility);

+ }

};

mContentViewRenderView.onNativeLibraryLoaded(window);

}