chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java - Issue 843883002: [Android] Fix a flicker in stopping Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java

Issue 843883002: [Android] Fix a flicker in stopping Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: added 'onActivityStop()' back in order not to break downstream Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java ('k') | content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java

index 97cea993e5ca7c1447a137b4e82cc269621bffc6..ec367537d10c052b6b7c2c5060f4eb644ba78c0a 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/TabManager.java

@@ -95,6 +95,12 @@ public class TabManager extends LinearLayout {

protected void onReadyToRender() {

if (mCurrentTab == null) createTab(mStartupUrl, TabLaunchType.FROM_RESTORE);

}

+ @Override

+ protected void onWindowVisibilityChanged(int visibility) {

+ if (visibility == View.GONE && mCurrentTab != null) mCurrentTab.hide();

+ super.onWindowVisibilityChanged(visibility);

+ }

};

mContentViewRenderView.onNativeLibraryLoaded(window);

mContentViewHolder.addView(mContentViewRenderView,