Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/Tab.java

Issue 843883002: [Android] Fix a flicker in stopping Chrome (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added 'onActivityStop()' back in order not to break downstream Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.app.Activity; 7 import android.app.Activity;
8 import android.content.Context; 8 import android.content.Context;
9 import android.graphics.Bitmap; 9 import android.graphics.Bitmap;
10 import android.graphics.Color; 10 import android.graphics.Color;
(...skipping 1069 matching lines...) Expand 10 before | Expand all | Expand 10 after
1080 1080
1081 // When resuming the activity, force an update to the fullscreen state t o ensure a 1081 // When resuming the activity, force an update to the fullscreen state t o ensure a
1082 // subactivity did not change the fullscreen configuration of this Chrom eTab's renderer in 1082 // subactivity did not change the fullscreen configuration of this Chrom eTab's renderer in
1083 // the case where it was shared (i.e. via an EmbedContentViewActivity). 1083 // the case where it was shared (i.e. via an EmbedContentViewActivity).
1084 updateFullscreenEnabledState(); 1084 updateFullscreenEnabledState();
1085 } 1085 }
1086 1086
1087 /** 1087 /**
1088 * Called on the foreground tab when the Activity is stopped. 1088 * Called on the foreground tab when the Activity is stopped.
1089 */ 1089 */
1090 // TODO(changwan): remove this
1090 public void onActivityStop() { 1091 public void onActivityStop() {
1091 hide(); 1092 hide();
1092 } 1093 }
1093 1094
1094 /** 1095 /**
1095 * Prepares the tab to be shown. This method is supposed to be called before the tab is 1096 * Prepares the tab to be shown. This method is supposed to be called before the tab is
1096 * displayed. It restores the ContentView if it is not available after the c old start and 1097 * displayed. It restores the ContentView if it is not available after the c old start and
1097 * reloads the tab if its renderer has crashed. 1098 * reloads the tab if its renderer has crashed.
1098 * @param type Specifies how the tab was selected. 1099 * @param type Specifies how the tab was selected.
1099 */ 1100 */
(...skipping 1281 matching lines...) Expand 10 before | Expand all | Expand 10 after
2381 private native boolean nativePrint(long nativeTabAndroid); 2382 private native boolean nativePrint(long nativeTabAndroid);
2382 private native Bitmap nativeGetFavicon(long nativeTabAndroid); 2383 private native Bitmap nativeGetFavicon(long nativeTabAndroid);
2383 private native void nativeCreateHistoricalTab(long nativeTabAndroid); 2384 private native void nativeCreateHistoricalTab(long nativeTabAndroid);
2384 private native void nativeUpdateTopControlsState( 2385 private native void nativeUpdateTopControlsState(
2385 long nativeTabAndroid, int constraints, int current, boolean animate ); 2386 long nativeTabAndroid, int constraints, int current, boolean animate );
2386 private native void nativeSearchByImageInNewTabAsync(long nativeTabAndroid); 2387 private native void nativeSearchByImageInNewTabAsync(long nativeTabAndroid);
2387 private native void nativeSetInterceptNavigationDelegate(long nativeTabAndro id, 2388 private native void nativeSetInterceptNavigationDelegate(long nativeTabAndro id,
2388 InterceptNavigationDelegate delegate); 2389 InterceptNavigationDelegate delegate);
2389 private static native void nativeRecordStartupToCommitUma(); 2390 private static native void nativeRecordStartupToCommitUma();
2390 } 2391 }
OLDNEW
« no previous file with comments | « no previous file | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698