Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Unified Diff: media/base/pipeline_unittest.cc

Issue 843863002: Revert current time clamp on ended; clamp paused time instead. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/pipeline_unittest.cc
diff --git a/media/base/pipeline_unittest.cc b/media/base/pipeline_unittest.cc
index b5e91bd036836b9e3d61eed53cd4fc3277482299..68e4590175d8bafb907e0a84b3eea3361a92d371 100644
--- a/media/base/pipeline_unittest.cc
+++ b/media/base/pipeline_unittest.cc
@@ -618,8 +618,8 @@ TEST_F(PipelineTest, EndedCallback) {
message_loop_.RunUntilIdle();
EXPECT_CALL(callbacks_, OnEnded());
- // There are cases where duration is reported wrong initially, so there is
- // an OnDurationChange event fired again on OnEnded event if required.
+ // Since the |ended_cb_| is manually invoked above, the duration does not
+ // match the expected duration and is updated upon ended.
EXPECT_CALL(callbacks_, OnDurationChange());
text_stream()->SendEosNotification();
message_loop_.RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698