Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 843843003: Exit with less stacktrace dump if we can't bind to the port (Closed)

Created:
5 years, 11 months ago by eseidel
Modified:
5 years, 11 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Exit with less stacktrace dump if we can't bind to the port R=jamesr@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/413cce374e8850cb5ee424a9d1a2c39fb4fda651

Patch Set 1 #

Patch Set 2 : Remove cout usage from prompt.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M sky/tools/debugger/prompt/prompt.cc View 1 3 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
Also removed iostream usage from prompt.cc since all those prints were racy. skydb currently prints ...
5 years, 11 months ago (2015-01-08 21:59:13 UTC) #1
jamesr
lgtm
5 years, 11 months ago (2015-01-08 22:01:13 UTC) #2
eseidel
5 years, 11 months ago (2015-01-08 22:02:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
413cce374e8850cb5ee424a9d1a2c39fb4fda651 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698