Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
843763004:
Use "static_assert" in lieu of "COMPILE_ASSERT" in ash module (Closed)
|
Created:
5 years, 11 months ago by anujsharma Modified:
5 years, 11 months ago Reviewers:
pkotwicz CC:
chromium-reviews, Mostyn Bramley-Moore Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUsing "static_assert" in lieu of "COMPILE_ASSERT" in ash module
All our toolchains support c++'s static_assert now- COMPILE_ASSERT can be removed now.
BUG=442514
Committed: https://crrev.com/dadaac36b84938d902807d1702bc609252b79f73
Cr-Commit-Position: refs/heads/master@{#312350}
Patch Set 1 #
Messages
Total messages: 19 (8 generated)
anujk.sharma@samsung.com changed reviewers: + pkotwicz@chromium.org
PTAL
lgtm
On 2015/01/20 18:07:36, pkotwicz wrote: > lgtm Thanks pkotwicz for lgtm.
The CQ bit was checked by anujk.sharma@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843763004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/11...) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...) Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
The CQ bit was checked by anujk.sharma@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843763004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/11...) win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)
The CQ bit was checked by anujk.sharma@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843763004/1
The CQ bit was unchecked by anujk.sharma@samsung.com
The CQ bit was checked by anujk.sharma@samsung.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843763004/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/dadaac36b84938d902807d1702bc609252b79f73 Cr-Commit-Position: refs/heads/master@{#312350} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
