Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: content/content_browsertests.isolate

Issue 843713002: Revert "Use Xvfb in isolated testing only if use_x11 is set" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/unit_tests.isolate ('k') | content/content_unittests.isolate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/content_browsertests.isolate
diff --git a/content/content_browsertests.isolate b/content/content_browsertests.isolate
index 9970f1371d2d8c67d502adc2880c568fd90e2a2b..53a53fc317a968f8d65d4cd2c1a1cfb2527b810e 100644
--- a/content/content_browsertests.isolate
+++ b/content/content_browsertests.isolate
@@ -33,18 +33,7 @@
],
},
}],
- ['use_x11==0', {
- 'variables': {
- 'command': [
- '../testing/test_env.py',
- '<(PRODUCT_DIR)/content_browsertests<(EXECUTABLE_SUFFIX)',
- '--test-launcher-bot-mode',
- '--asan=<(asan)',
- '--lsan=<(lsan)',
- ],
- },
- }],
- ['use_x11==1', {
+ ['OS=="linux"', {
'variables': {
'command': [
'../testing/xvfb.py',
@@ -56,17 +45,17 @@
],
'files': [
'../testing/xvfb.py',
- '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
+ '<(PRODUCT_DIR)/content_shell.pak',
+ '<(PRODUCT_DIR)/libffmpegsumo.so',
+ '<(PRODUCT_DIR)/libosmesa.so',
+ '<(PRODUCT_DIR)/libppapi_tests.so',
],
},
}],
- ['OS=="linux"', {
+ ['OS=="linux" and use_ozone==0', {
'variables': {
'files': [
- '<(PRODUCT_DIR)/content_shell.pak',
- '<(PRODUCT_DIR)/libffmpegsumo.so',
- '<(PRODUCT_DIR)/libosmesa.so',
- '<(PRODUCT_DIR)/libppapi_tests.so',
+ '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
],
},
}],
@@ -95,6 +84,17 @@
],
},
}],
+ ['OS=="mac" or OS=="win"', {
+ 'variables': {
+ 'command': [
+ '../testing/test_env.py',
+ '<(PRODUCT_DIR)/content_browsertests<(EXECUTABLE_SUFFIX)',
+ '--test-launcher-bot-mode',
+ '--asan=<(asan)',
+ '--lsan=<(lsan)',
+ ],
+ },
+ }],
['OS=="win"', {
'variables': {
'files': [
« no previous file with comments | « chrome/unit_tests.isolate ('k') | content/content_unittests.isolate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698