Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: base/base_unittests.isolate

Issue 843713002: Revert "Use Xvfb in isolated testing only if use_x11 is set" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ash/ash_unittests.isolate ('k') | build/android/pylib/utils/isolator.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'conditions': [ 5 'conditions': [
6 ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', { 6 ['OS=="android" or OS=="linux" or OS=="mac" or OS=="win"', {
7 'variables': { 7 'variables': {
8 'files': [ 8 'files': [
9 'test/data/', 9 'test/data/',
10 ], 10 ],
11 }, 11 },
12 }], 12 }],
13 ['use_x11==0', { 13 ['OS=="linux"', {
14 'variables': {
15 'command': [
16 '../testing/test_env.py',
17 '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
18 '--brave-new-test-launcher',
19 '--test-launcher-bot-mode',
20 '--asan=<(asan)',
21 '--lsan=<(lsan)',
22 ],
23 },
24 }],
25 ['use_x11==1', {
26 'variables': { 14 'variables': {
27 'command': [ 15 'command': [
28 '../testing/xvfb.py', 16 '../testing/xvfb.py',
29 '<(PRODUCT_DIR)', 17 '<(PRODUCT_DIR)',
30 '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)', 18 '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
31 '--brave-new-test-launcher', 19 '--brave-new-test-launcher',
32 '--test-launcher-bot-mode', 20 '--test-launcher-bot-mode',
33 '--asan=<(asan)', 21 '--asan=<(asan)',
34 '--lsan=<(lsan)', 22 '--lsan=<(lsan)',
35 ], 23 ],
36 'files': [ 24 'files': [
37 '../testing/xvfb.py', 25 '../testing/xvfb.py',
26 ],
27 },
28 }],
29 ['OS=="linux" and use_ozone==0', {
30 'variables': {
31 'files': [
38 '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)', 32 '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
39 ], 33 ],
40 }, 34 },
41 }], 35 }],
42 ['OS=="linux" or OS=="mac" or OS=="win"', { 36 ['OS=="linux" or OS=="mac" or OS=="win"', {
43 'variables': { 37 'variables': {
44 'files': [ 38 'files': [
45 '../testing/test_env.py', 39 '../testing/test_env.py',
46 '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)', 40 '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
47 ], 41 ],
48 'read_only': 1, 42 'read_only': 1,
49 }, 43 },
50 }], 44 }],
45 ['OS=="mac" or OS=="win"', {
46 'variables': {
47 'command': [
48 '../testing/test_env.py',
49 '<(PRODUCT_DIR)/base_unittests<(EXECUTABLE_SUFFIX)',
50 '--brave-new-test-launcher',
51 '--test-launcher-bot-mode',
52 '--asan=<(asan)',
53 '--lsan=<(lsan)',
54 ],
55 },
56 }],
51 ['OS=="win" and (fastbuild==0 or fastbuild==1)', { 57 ['OS=="win" and (fastbuild==0 or fastbuild==1)', {
52 'variables': { 58 'variables': {
53 'files': [ 59 'files': [
54 '<(PRODUCT_DIR)/base_unittests.exe.pdb', 60 '<(PRODUCT_DIR)/base_unittests.exe.pdb',
55 ], 61 ],
56 }, 62 },
57 }], 63 }],
58 ], 64 ],
59 'includes': [ 65 'includes': [
60 'base.isolate', 66 'base.isolate',
61 ], 67 ],
62 } 68 }
OLDNEW
« no previous file with comments | « ash/ash_unittests.isolate ('k') | build/android/pylib/utils/isolator.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698