Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: webkit/plugins/ppapi/message_channel.h

Issue 8437093: Make PostMessageToJavaScript use new WebKit API instead of script. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: One more review fix. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/tests/test_case.html ('k') | webkit/plugins/ppapi/message_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/message_channel.h
diff --git a/webkit/plugins/ppapi/message_channel.h b/webkit/plugins/ppapi/message_channel.h
index d7979f1bf557b6434ea51e44163eabc0a2cf7a6c..05a468e0adc2558886f679dd1db9d05e853b775b 100644
--- a/webkit/plugins/ppapi/message_channel.h
+++ b/webkit/plugins/ppapi/message_channel.h
@@ -10,6 +10,9 @@
#include "third_party/npapi/bindings/npruntime.h"
struct PP_Var;
+namespace WebKit {
+class WebSerializedScriptValue;
+}
namespace webkit {
namespace ppapi {
@@ -80,18 +83,10 @@ class MessageChannel {
// The NPObject we use to expose postMessage to JavaScript.
MessageChannelNPObject* np_object_;
- // An NPVariant referring to the JavaScript function we use to send a message
- // to a JavaScript target.
- NPVariant onmessage_invoker_;
-
- // Evaluates the JavaScript code for onmessage_invoker_ and makes
- // it a callable NPVariant for that function. Returns true on success, false
- // otherwise.
- bool EvaluateOnMessageInvoker();
-
// Post a message to the onmessage handler for this channel's instance
// synchronously. This is used by PostMessageToJavaScript.
- void PostMessageToJavaScriptImpl(PP_Var message_data);
+ void PostMessageToJavaScriptImpl(
+ const WebKit::WebSerializedScriptValue& message_data);
// Post a message to the PPP_Instance HandleMessage function for this
// channel's instance. This is used by PostMessageToNative.
void PostMessageToNativeImpl(PP_Var message_data);
« no previous file with comments | « ppapi/tests/test_case.html ('k') | webkit/plugins/ppapi/message_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698