Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 843683003: Revert of Only run install-debian.wheezy.sysroot.py once during runhooks (Closed)

Created:
5 years, 11 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 11 months ago
Reviewers:
Lei Zhang, Sam Clegg
CC:
chromium-reviews, grt+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Only run install-debian.wheezy.sysroot.py once during runhooks (patchset #2 id:20001 of https://codereview.chromium.org/834133003/) Reason for revert: See failing gclient runhooks after this patch and the Chrome build tree turned red (see http://build.chromium.org/p/chromium.win/waterfall?builder=Win8%20GN for details). I can't find any other reason for this failure and will will try to revert. Original issue's description: > Only run install-debian.wheezy.sysroot.py once during runhooks > > This script was previously run three times, once for > each arch, with two of the three always being no-ops. > > Instead just run the script once and have the script > figure out which image to download. > > TEST=trybots + 'gclient runhooks' locally > > Committed: https://crrev.com/711802679ce2feb228ad418dd117ae23301e5c02 > Cr-Commit-Position: refs/heads/master@{#310467} TBR=thestig@chromium.org,sbc@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/9c5c0565bfe3b438b018fc284f752f7766fdd9ea Cr-Commit-Position: refs/heads/master@{#310468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -53 lines) Patch
M DEPS View 1 chunk +22 lines, -1 line 0 comments Download
M chrome/installer/linux/sysroot_scripts/install-debian.wheezy.sysroot.py View 7 chunks +45 lines, -52 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
henrika (OOO until Aug 14)
Created Revert of Only run install-debian.wheezy.sysroot.py once during runhooks
5 years, 11 months ago (2015-01-08 10:46:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843683003/1
5 years, 11 months ago (2015-01-08 10:47:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-08 10:49:00 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 10:50:24 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c5c0565bfe3b438b018fc284f752f7766fdd9ea
Cr-Commit-Position: refs/heads/master@{#310468}

Powered by Google App Engine
This is Rietveld 408576698