Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 843643002: Cleanup: Remove some redundant container clear() calls. (Closed)

Created:
5 years, 11 months ago by Lei Zhang
Modified:
5 years, 11 months ago
CC:
asanka, benjhayden+dwatch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, davemoore+watch_chromium.org, erikwright+watch_chromium.org, extensions-reviews_chromium.org, jam, nkostylev+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, stuartmorgan+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove some redundant container clear() calls. The STL utility functions already clear containers. Committed: https://crrev.com/47be1d748166b47cf8ce838b889051aba3735eb8 Cr-Commit-Position: refs/heads/master@{#310608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -17 lines) Patch
M base/prefs/pref_value_map.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/plugins/plugin_finder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/search_engines/template_url_table_model.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/invalidation/sync_system_resources.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/download/download_item_impl_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/download/download_manager_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/extension_pref_value_map.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_session.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/spdy/spdy_read_queue.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Lei Zhang
asanka: content and net finnur: base, chrome, and extensions jochen: components
5 years, 11 months ago (2015-01-08 03:50:11 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-08 13:04:57 UTC) #3
Finnur
LGTM
5 years, 11 months ago (2015-01-08 14:00:53 UTC) #4
asanka
LGTM for //content and //net. Thanks
5 years, 11 months ago (2015-01-08 19:21:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843643002/1
5 years, 11 months ago (2015-01-08 21:26:12 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-08 21:59:02 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 22:00:03 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/47be1d748166b47cf8ce838b889051aba3735eb8
Cr-Commit-Position: refs/heads/master@{#310608}

Powered by Google App Engine
This is Rietveld 408576698