Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ui/base/BUILD.gn

Issue 843583006: GN: Add -Wl,-z defs on linux and fix errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes for android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« device/vibration/android/BUILD.gn ('K') | « ui/aura/BUILD.gn ('k') | ui/display/util/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index 6b034af05dbf4b99da72e6815079ea03baddd115..7dd7222d8236e85c9462d0cdad04b8bedd595cf4 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -304,6 +304,7 @@ component("base") {
"//base:i18n",
"//net",
"//third_party/icu",
+ "//ui/events",
"//ui/events/devices",
"//ui/resources",
"//ui/strings",
@@ -311,10 +312,6 @@ component("base") {
]
if (build_ime) {
- if (!is_android) {
- deps += [ "//ui/events" ]
- }
-
sources += [
"ime/candidate_window.cc",
"ime/candidate_window.h",
« device/vibration/android/BUILD.gn ('K') | « ui/aura/BUILD.gn ('k') | ui/display/util/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698