Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Side by Side Diff: device/vibration/android/BUILD.gn

Issue 843583006: GN: Add -Wl,-z defs on linux and fix errors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes for android Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/test/BUILD.gn ('k') | gpu/config/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/android/rules.gni") 6 import("//build/config/android/rules.gni")
7 7
8 assert(is_android) 8 assert(is_android)
9 9
10 source_set("android") { 10 source_set("android") {
11 sources = [ 11 sources = [
12 "vibration_jni_registrar.cc", 12 "vibration_jni_registrar.cc",
13 "vibration_jni_registrar.h", 13 "vibration_jni_registrar.h",
14 ] 14 ]
15 15
16 defines = [ "DEVICE_VIBRATION_IMPLEMENTATION" ]
Nico 2015/01/16 01:57:50 For a source_set? Shouldn't this be where the comp
17
16 deps = [ 18 deps = [
17 # vibration_jni_registrar.cc includes a header from device/vibration 19 # vibration_jni_registrar.cc includes a header from device/vibration
18 # that includes a mojo-generated header file. Make sure the header 20 # that includes a mojo-generated header file. Make sure the header
19 # is generated before vibration_jni_registrar.cc is compiled. 21 # is generated before vibration_jni_registrar.cc is compiled.
20 "//device/vibration:mojo_bindings", 22 "//device/vibration:mojo_bindings",
21 ] 23 ]
22 } 24 }
23 25
24 generate_jni("vibration_jni_headers") { 26 generate_jni("vibration_jni_headers") {
25 sources = [ 27 sources = [
26 "java/src/org/chromium/device/vibration/VibrationProvider.java", 28 "java/src/org/chromium/device/vibration/VibrationProvider.java",
27 ] 29 ]
28 jni_package = "vibration" 30 jni_package = "vibration"
29 } 31 }
OLDNEW
« no previous file with comments | « content/test/BUILD.gn ('k') | gpu/config/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698