Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Unified Diff: content/browser/service_worker/service_worker_version.h

Issue 843583005: [ServiceWorker] Implement WebServiceWorkerContextClient::openWindow(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@content_browser_client_openurl
Patch Set: jochen review comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index e9ba2be1d8e22c5914fa9eb841b98ca226b79b56..f9bcda7e7d536f93002d4f8a6c713356272a0e38 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -347,17 +347,26 @@ class CONTENT_EXPORT ServiceWorkerVersion
void OnGeofencingEventFinished(int request_id);
void OnCrossOriginConnectEventFinished(int request_id,
bool accept_connection);
+ void OnOpenWindow(int request_id, const GURL& url);
+ void DidOpenWindow(int request_id,
+ int render_process_id,
+ int render_frame_id);
+ void OnOpenWindowFinished(int request_id,
+ int client_id,
+ const ServiceWorkerClientInfo& client_info);
+
void OnPostMessageToDocument(int client_id,
const base::string16& message,
const std::vector<int>& sent_message_port_ids);
void OnFocusClient(int request_id, int client_id);
void OnSkipWaiting(int request_id);
-
void OnFocusClientFinished(int request_id, bool result);
+
void DidSkipWaiting(int request_id);
void DidGetClientInfo(int client_id,
scoped_refptr<GetClientDocumentsCallback> callback,
const ServiceWorkerClientInfo& info);
+
void ScheduleStopWorker();
void StopWorkerIfIdle();
bool HasInflightRequests() const;
@@ -394,6 +403,7 @@ class CONTENT_EXPORT ServiceWorkerVersion
ControlleeMap controllee_map_;
ControlleeByIDMap controllee_by_id_;
+ // Will be null while shutting down.
base::WeakPtr<ServiceWorkerContextCore> context_;
ObserverList<Listener> listeners_;
ServiceWorkerScriptCacheMap script_cache_map_;

Powered by Google App Engine
This is Rietveld 408576698