Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3672)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 843583005: [ServiceWorker] Implement WebServiceWorkerContextClient::openWindow(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@content_browser_client_openurl
Patch Set: jochen review comments Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 7447abb9f062b62bd0556cc0994803d1a125dbc6..0e95da51a95adb680c2f394c56925843c2916f51 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -2567,6 +2567,27 @@ bool ChromeContentBrowserClient::CheckMediaAccessPermission(
browser_context, security_origin, type);
}
+content::WebContents* ChromeContentBrowserClient::OpenURL(
+ content::BrowserContext* browser_context,
+ const content::OpenURLParams& params) {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
+
+#if !defined(OS_ANDROID) && !defined(OS_IOS)
+ NavigateParams nav_params(Profile::FromBrowserContext(browser_context),
+ params.url,
+ params.transition);
+ FillNavigateParamsFromOpenURLParams(&nav_params, params);
+ nav_params.user_gesture = params.user_gesture;
+
+ Navigate(&nav_params);
+ return nav_params.target_contents;
+#else
+ // TODO(mlamouri): write a chrome::Navigate() method for Android and iOS.
+ // See https://crbug.com/448409.
+ return nullptr;
+#endif // !defined(OS_ANDROID) && !defined(OS_IOS)
+}
+
content::DevToolsManagerDelegate*
ChromeContentBrowserClient::GetDevToolsManagerDelegate() {
#if defined(OS_ANDROID)

Powered by Google App Engine
This is Rietveld 408576698