content/renderer/service_worker/embedded_worker_context_client.h - Issue 843583005: [ServiceWorker] Implement WebServiceWorkerContextClient::openWindow().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/service_worker/embedded_worker_context_client.h

Issue 843583005: [ServiceWorker] Implement WebServiceWorkerContextClient::openWindow(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@content_browser_client_openurl

Patch Set: review comments Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/browser/content_browser_client.cc ('k') | content/renderer/service_worker/embedded_worker_context_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/service_worker/embedded_worker_context_client.h

diff --git a/content/renderer/service_worker/embedded_worker_context_client.h b/content/renderer/service_worker/embedded_worker_context_client.h

index 9cf85955e2b760b22b07d701aebdb6e2782c1ebb..573e37125cbe377211c868be662d67cdb2c9d83a 100644

--- a/content/renderer/service_worker/embedded_worker_context_client.h

+++ b/content/renderer/service_worker/embedded_worker_context_client.h

@@ -64,6 +64,8 @@ class EmbeddedWorkerContextClient

virtual blink::WebServiceWorkerCacheStorage* cacheStorage();

virtual void didPauseAfterDownload();

virtual void getClients(blink::WebServiceWorkerClientsCallbacks*);

+ virtual void openWindow(const blink::WebURL&,

+ blink::WebServiceWorkerClientCallbacks*);

virtual void workerReadyForInspection();

virtual void workerContextFailedToStart();

virtual void workerContextStarted(blink::WebServiceWorkerContextProxy* proxy);