content/browser/service_worker/service_worker_provider_host.cc - Issue 843583005: [ServiceWorker] Implement WebServiceWorkerContextClient::openWindow().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_provider_host.cc

Issue 843583005: [ServiceWorker] Implement WebServiceWorkerContextClient::openWindow(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@content_browser_client_openurl

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_provider_host.h ('k') | content/browser/service_worker/service_worker_version.h » ('j') | content/browser/service_worker/service_worker_version.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_provider_host.cc

diff --git a/content/browser/service_worker/service_worker_provider_host.cc b/content/browser/service_worker/service_worker_provider_host.cc

index 6153b93a747902920cd1602d5151efd0853a289b..04ed495100e1eeaebc7874c0ddff1a58d820b48d 100644

--- a/content/browser/service_worker/service_worker_provider_host.cc

+++ b/content/browser/service_worker/service_worker_provider_host.cc

@@ -245,7 +245,7 @@ void ServiceWorkerProviderHost::Focus(const FocusCallback& callback) {

void ServiceWorkerProviderHost::GetClientInfo(

int embedded_worker_id,

michaeln 2015/01/17 00:25:32 why is this first param here?

mlamouri (slow - plz ping) 2015/01/26 13:19:08 No longer apply with the rebase.

- int request_id) {

+ int request_id) const {

dispatcher_host_->Send(new ServiceWorkerMsg_GetClientInfo(

kDocumentMainThreadId, embedded_worker_id, request_id, provider_id()));

}