Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 843523002: Delete empty mojo python package, and prefix all python packages with mojo_ (Closed)

Created:
5 years, 11 months ago by etiennej
Modified:
5 years, 11 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete empty mojo python package, and prefix all python packages with mojo_ R=qsr@chromium.org, qsr Committed: https://chromium.googlesource.com/external/mojo/+/9cbb611add0c3f2bf0d60b65e5fe9e4517fbf2c1

Patch Set 1 #

Total comments: 7

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -3401 lines) Patch
M mojo/public/python/BUILD.gn View 5 chunks +23 lines, -36 lines 0 comments Download
A + mojo/public/python/c_async_waiter.pxd View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/python/c_core.pxd View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/python/c_environment.pxd View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/python/c_export.pxd View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/python/c_thunks.pxd View 0 chunks +-1 lines, --1 lines 0 comments Download
D mojo/public/python/mojo/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/public/python/mojo/bindings/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/public/python/mojo/bindings/descriptor.py View 1 chunk +0 lines, -696 lines 0 comments Download
D mojo/public/python/mojo/bindings/messaging.py View 1 chunk +0 lines, -407 lines 0 comments Download
D mojo/public/python/mojo/bindings/promise.py View 1 chunk +0 lines, -196 lines 0 comments Download
D mojo/public/python/mojo/bindings/reflection.py View 1 chunk +0 lines, -569 lines 0 comments Download
D mojo/public/python/mojo/bindings/serialization.py View 1 chunk +0 lines, -193 lines 0 comments Download
D mojo/public/python/mojo/c_async_waiter.pxd View 1 chunk +0 lines, -28 lines 0 comments Download
D mojo/public/python/mojo/c_core.pxd View 1 chunk +0 lines, -201 lines 0 comments Download
D mojo/public/python/mojo/c_environment.pxd View 1 chunk +0 lines, -35 lines 0 comments Download
D mojo/public/python/mojo/c_export.pxd View 1 chunk +0 lines, -11 lines 0 comments Download
D mojo/public/python/mojo/c_thunks.pxd View 1 chunk +0 lines, -12 lines 0 comments Download
D mojo/public/python/mojo/system.pyx View 1 chunk +0 lines, -804 lines 0 comments Download
D mojo/public/python/mojo/system_impl.pyx View 1 chunk +0 lines, -75 lines 0 comments Download
A + mojo/public/python/mojo_bindings/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/python/mojo_bindings/descriptor.py View 5 chunks +9 lines, -9 lines 0 comments Download
A + mojo/public/python/mojo_bindings/messaging.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/public/python/mojo_bindings/promise.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/python/mojo_bindings/reflection.py View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/public/python/mojo_bindings/serialization.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/public/python/mojo_system.pyx View 3 chunks +3 lines, -3 lines 0 comments Download
A + mojo/public/python/mojo_system_impl.pyx View 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/public/tools/bindings/generators/python_templates/module.py.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/python/BUILD.gn View 1 chunk +9 lines, -9 lines 0 comments Download
D mojo/python/system/mojo/embedder.pyx View 1 chunk +0 lines, -50 lines 0 comments Download
D mojo/python/system/mojo/tests/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
D mojo/python/system/mojo/tests/validation_util.pyx View 1 chunk +0 lines, -35 lines 0 comments Download
A + mojo/python/system/mojo_embedder.pyx View 2 chunks +4 lines, -4 lines 0 comments Download
A + mojo/python/system/mojo_tests/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + mojo/python/system/mojo_tests/validation_util.pyx View 0 chunks +-1 lines, --1 lines 0 comments Download
M mojo/python/tests/async_wait_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/python/tests/bindings_interface_unittest.py View 1 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/python/tests/bindings_serialization_deserialization_unittest.py View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/python/tests/bindings_structs_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/python/tests/generation_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/python/tests/messaging_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/python/tests/mojo_unittest.py View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/python/tests/promise_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/python/tests/runloop_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/python/tests/system_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/python/tests/validation_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
etiennej
5 years, 11 months ago (2015-01-07 16:26:11 UTC) #1
qsr
LGTM with nits. https://codereview.chromium.org/843523002/diff/1/mojo/public/python/BUILD.gn File mojo/public/python/BUILD.gn (right): https://codereview.chromium.org/843523002/diff/1/mojo/public/python/BUILD.gn#newcode17 mojo/public/python/BUILD.gn:17: python_base_module = "" Is that necessary? ...
5 years, 11 months ago (2015-01-07 18:17:55 UTC) #2
etiennej
https://codereview.chromium.org/843523002/diff/1/mojo/public/python/BUILD.gn File mojo/public/python/BUILD.gn (right): https://codereview.chromium.org/843523002/diff/1/mojo/public/python/BUILD.gn#newcode17 mojo/public/python/BUILD.gn:17: python_base_module = "" On 2015/01/07 18:17:55, qsr wrote: > ...
5 years, 11 months ago (2015-01-08 09:23:04 UTC) #3
qsr
https://codereview.chromium.org/843523002/diff/1/mojo/public/python/BUILD.gn File mojo/public/python/BUILD.gn (right): https://codereview.chromium.org/843523002/diff/1/mojo/public/python/BUILD.gn#newcode17 mojo/public/python/BUILD.gn:17: python_base_module = "" On 2015/01/08 09:23:04, etiennej wrote: > ...
5 years, 11 months ago (2015-01-08 10:23:20 UTC) #4
etiennej
5 years, 11 months ago (2015-01-08 13:21:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
9cbb611add0c3f2bf0d60b65e5fe9e4517fbf2c1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698