sync: add more integration tests for wifi_sync

chrome/browser/sync/test/integration/single_client_wifi_credentials_sync_test.cc

Index: chrome/browser/sync/test/integration/single_client_wifi_credentials_sync_test.cc
diff --git a/chrome/browser/sync/test/integration/single_client_wifi_credentials_sync_test.cc b/chrome/browser/sync/test/integration/single_client_wifi_credentials_sync_test.cc
index f8c68aa85ee5442ed0fc8d3004451227ee119b84..968e464da1d0ea6a3ffdc26012f0339fb4a43e5e 100644
--- a/chrome/browser/sync/test/integration/single_client_wifi_credentials_sync_test.cc
+++ b/chrome/browser/sync/test/integration/single_client_wifi_credentials_sync_test.cc
@@ -4,20 +4,36 @@
 
 #include "base/command_line.h"
 #include "base/macros.h"
+#include "chrome/browser/sync/test/integration/sync_integration_test_util.h"
 #include "chrome/browser/sync/test/integration/sync_test.h"
 #include "chrome/browser/sync/test/integration/wifi_credentials_helper.h"
 #include "chrome/common/chrome_switches.h"
+#include "components/wifi_sync/wifi_credential.h"
+#include "components/wifi_sync/wifi_security_class.h"
+
+using sync_integration_test_util::AwaitCommitActivityCompletion;
+using wifi_sync::WifiCredential;
 
 class SingleClientWifiCredentialsSyncTest : public SyncTest {
  public:
   SingleClientWifiCredentialsSyncTest() : SyncTest(SINGLE_CLIENT) {}
   ~SingleClientWifiCredentialsSyncTest() override {}
 

[stevenjb, 2015/01/28 21:29:43]

// SyncTest

[mukesh agrawal, 2015/01/28 22:55:11]

Done.

+  void SetUp() override {
+    wifi_credentials_helper::SetUp();
+    SyncTest::SetUp();
+  }
+
   void SetUpCommandLine(base::CommandLine* command_line) override {
     SyncTest::SetUpCommandLine(command_line);
     command_line->AppendSwitch(switches::kEnableWifiCredentialSync);
   }
 
+  bool SetupClients() override {
+    return SyncTest::SetupClients() &&
+        wifi_credentials_helper::SetupClients();
+  }
+
  private:
   DISALLOW_COPY_AND_ASSIGN(SingleClientWifiCredentialsSyncTest);
 };
@@ -27,3 +43,16 @@ IN_PROC_BROWSER_TEST_F(SingleClientWifiCredentialsSyncTest, NoCredentials) {
   ASSERT_TRUE(wifi_credentials_helper::VerifierIsEmpty());
   ASSERT_TRUE(wifi_credentials_helper::ProfileMatchesVerifier(0));
 }
+
+IN_PROC_BROWSER_TEST_F(SingleClientWifiCredentialsSyncTest, SingleCredential) {
+  ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
+  const size_t profile_index = 0;
+  wifi_credentials_helper::AddWifiCredential(
+      profile_index,
+      "fake_id",
+      wifi_credentials_helper::MakeWifiCredential(
+          "fake-ssid", wifi_sync::SECURITY_CLASS_PSK, "fake_passphrase"));

[stevenjb, 2015/01/28 21:29:43]

I would call MakeWifiCredential separately and assert that it succeeds (see
comment in MakeWifiCredential).

[mukesh agrawal, 2015/01/28 22:55:11]

Done.

+  ASSERT_TRUE(AwaitCommitActivityCompletion(GetSyncService((0))));
+  ASSERT_FALSE(wifi_credentials_helper::VerifierIsEmpty());
+  ASSERT_TRUE(wifi_credentials_helper::ProfileMatchesVerifier(0));

[stevenjb, 2015/01/28 21:29:43]

The last two could probably be EXPECT instead of assert?

[mukesh agrawal, 2015/01/28 22:55:11]

Done.

+}