sync: add more integration tests for wifi_sync

chrome/browser/sync/test/integration/wifi_credentials_helper_chromeos.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SYNC_TEST_INTEGRATION_WIFI_CREDENTIALS_HELPER_CHROMEOS_H_
 #define CHROME_BROWSER_SYNC_TEST_INTEGRATION_WIFI_CREDENTIALS_HELPER_CHROMEOS_H_
 
 #include "components/wifi_sync/wifi_credential.h"
 
 class Profile;
 
 namespace wifi_credentials_helper {

[pneubeck (no reviews), 2015/01/30 14:38:45]

some of this code is for testing only, please consider making that more clear.
E.g. at each function (function name or at least a comment) or the
namespace&filename.

[mukesh agrawal, 2015/01/30 22:28:14]

Actually, _all_ of this code is for testing only :). This code exists only to
support the tests in  {single,two}_client_wifi_credentials_sync_test.cc.

I believe that the fact that this is test support code is communicated by the
location of the code ("sync/test/integration"), and the file name ("helper").

Given that all of these functions are for testing, I think per-function
comments/names would be noise. I could add a file-level comment, if you'd like.
(I think it would be inconsistent with the other helpers in this directory, but
I don't feel too strongly about that.)

[pneubeck (no reviews), 2015/01/31 10:26:40]

sorry, I actually missed the /test/ part of the path. again, this is not so
common in chrome.

[mukesh agrawal, 2015/02/02 20:36:40]

Acknowledged.

 
+namespace chromeos {
+
+// Performs ChromeOS-specific setup.
+void SetUpChromeOs();
+
+// Performs ChromeOS-specific setup for a given sync client, given

[pneubeck (no reviews), 2015/01/30 14:38:45]

should be called only after SetUpChromeOs ?

[mukesh agrawal, 2015/01/30 22:28:14]

Done.

+// that client's Profile.
+bool SetupClientForProfileChromeOs(const Profile* profile);

[pneubeck (no reviews), 2015/01/30 14:38:45]

if these function can use BrowserContext instead of Profile, please do so.

[mukesh agrawal, 2015/01/30 22:28:14]

Done.

+
+// Adds a WiFi credential to the ChromeOS networking backend,
+// associating the credential with the ChromeOS networking state that
+// corresonds to |profile|.
+void AddWifiCredentialToProfileChromeOs(
+    Profile* profile, const wifi_sync::WifiCredential& credential);
+
 // Returns the ChromeOS WiFi credentials associated with |profile|.
 wifi_sync::WifiCredential::CredentialSet GetWifiCredentialsForProfileChromeOs(
     const Profile* profile);
 
+}  // namespace chromeos
+
 }  // namespace wifi_credentials_helper
 
 #endif  // CHROME_BROWSER_SYNC_TEST_INTEGRATION_WIFI_CREDENTIALS_HELPER_CHROMEOS_H_