Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 843463002: Add print and getSelectedText functions to the OOP PDF scripting API (Closed)

Created:
5 years, 11 months ago by raymes
Modified:
5 years, 11 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@postMessage-api
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add print and getSelectedText functions to the OOP PDF scripting API These are needed by some internal users (see the bug for more details). A test is added for selectAll/getSelectedText. BUG=415858 Committed: https://crrev.com/d914d7d0903eda0b9ae77c5d0adb7a6a61c95e13 Cr-Commit-Position: refs/heads/master@{#311218}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -2 lines) Patch
M chrome/browser/resources/pdf/pdf.js View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/pdf_scripting_api.js View 1 2 3 chunks +44 lines, -1 line 0 comments Download
M chrome/test/data/pdf/basic_plugin_test.js View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M pdf/out_of_process_instance.cc View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
raymes
5 years, 11 months ago (2015-01-07 04:09:38 UTC) #2
Sam McNally
LGTM https://codereview.chromium.org/843463002/diff/20001/chrome/browser/resources/pdf/pdf_scripting_api.js File chrome/browser/resources/pdf/pdf_scripting_api.js (right): https://codereview.chromium.org/843463002/diff/20001/chrome/browser/resources/pdf/pdf_scripting_api.js#newcode134 chrome/browser/resources/pdf/pdf_scripting_api.js:134: * Get accessibility JSON for the document. Must ...
5 years, 11 months ago (2015-01-08 04:00:59 UTC) #3
raymes
https://codereview.chromium.org/843463002/diff/20001/chrome/browser/resources/pdf/pdf_scripting_api.js File chrome/browser/resources/pdf/pdf_scripting_api.js (right): https://codereview.chromium.org/843463002/diff/20001/chrome/browser/resources/pdf/pdf_scripting_api.js#newcode134 chrome/browser/resources/pdf/pdf_scripting_api.js:134: * Get accessibility JSON for the document. Must be ...
5 years, 11 months ago (2015-01-08 22:23:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843463002/40001
5 years, 11 months ago (2015-01-09 00:04:42 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-09 01:57:26 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/7b1df224a957da8376e0ae71ab2d53dabf658b0a Cr-Commit-Position: refs/heads/master@{#310663}
5 years, 11 months ago (2015-01-09 01:58:20 UTC) #10
keishi
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/843923002/ by keishi@chromium.org. ...
5 years, 11 months ago (2015-01-09 05:56:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843463002/60001
5 years, 11 months ago (2015-01-13 02:07:58 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/48294)
5 years, 11 months ago (2015-01-13 02:19:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/843463002/60001
5 years, 11 months ago (2015-01-13 03:49:00 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 11 months ago (2015-01-13 05:03:12 UTC) #18
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 05:04:13 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d914d7d0903eda0b9ae77c5d0adb7a6a61c95e13
Cr-Commit-Position: refs/heads/master@{#311218}

Powered by Google App Engine
This is Rietveld 408576698