Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5447)

Unified Diff: chrome/common/extensions/api/content_settings.json

Issue 843413003: Add `chrome.contentSettings.location`. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Feedback. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/content_settings.json
diff --git a/chrome/common/extensions/api/content_settings.json b/chrome/common/extensions/api/content_settings.json
index 5d21a7030eb98e8ce1e3d3f7e40d1f5bc9cca198..6f09fc4a49780fe1dcf2f678a08f245a1871093a 100644
--- a/chrome/common/extensions/api/content_settings.json
+++ b/chrome/common/extensions/api/content_settings.json
@@ -197,6 +197,14 @@
{"type":"string", "enum": ["allow", "block"]}
]
},
+ "location": {
+ "$ref": "ContentSetting",
+ "description": "Whether to allow Geolocation. One of <br><var>allow</var>: Allow sites to track your physical location,<br><var>block</var>: Don't allow sites to track your physical location,<br><var>ask</var>: Ask before allowing sites to track your physical location. <br>Default is <var>ask</var>.<br>The primary URL is the main-frame URL. The secondary URL is the URL of the top-level frame.",
Bernhard Bauer 2015/01/13 10:52:49 This comment still doesn't make much sense. The ma
Mike West 2015/01/13 13:00:30 The main frame is the frame of the document whose
Bernhard Bauer 2015/01/13 23:09:37 Not really. In other content setting types, "main-
+ "value": [
+ "location",
+ {"type":"string", "enum": ["allow", "block", "ask"]}
+ ]
+ },
"plugins": {
"$ref": "ContentSetting",
"description": "Whether to run plug-ins. One of<br><var>allow</var>: Run plug-ins automatically,<br><var>block</var>: Don't run plug-ins automatically. <br>Default is <var>allow</var>.<br>The primary URL is the main-frame URL. The secondary URL is not used.",

Powered by Google App Engine
This is Rietveld 408576698