Add `chrome.contentSettings.location`.

Add `chrome.contentSettings.location`.

Most everything was already in place for this, we just needed to wire
it up to the external API.

BUG=447989
R=bauerb@chromium.org,kalman@chromium.org

Committed: https://crrev.com/6b72640c72774ba56f537a17cf3b4b5f71e9e5dd
Cr-Commit-Position: refs/heads/master@{#311462}

[Mike West, 2015-01-12 11:13:33]

Mind taking a look?

-mike

[Mike West, 2015-01-12 11:13:33]

Mind taking a look?

-mike

[Mike West, 2015-01-12 11:13:33]

Mind taking a look?

-mike

[Mike West, 2015-01-12 11:13:34]

Mind taking a look?

-mike

[Mike West, 2015-01-12 11:14:01]

+msramek: FYI.

[msramek, 2015-01-12 11:37:40]

msramek@chromium.org changed reviewers:
+ msramek@chromium.org

[msramek, 2015-01-12 11:37:41]

https://codereview.chromium.org/843413003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/content_settings.json (right):

https://codereview.chromium.org/843413003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/content_settings.json:202: "description": "Whether
to allow Geolocation. One of <br><var>allow</var>: Allow sites to track your
physical location,<br><var>block</var>: Don't allow sites to track your physical
location,<br><var>block</var>: Ask before allowing sites to track your physical
location. <br>Default is <var>ask</var>.<br>The primary URL is the main-frame
URL. The secondary URL is not used.",
"<br><var>block</var>: Ask before"

s/block/ask/

[Bernhard Bauer, 2015-01-12 14:35:58]

https://codereview.chromium.org/843413003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/content_settings.json (right):

https://codereview.chromium.org/843413003/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/content_settings.json:202: "description": "Whether
to allow Geolocation. One of <br><var>allow</var>: Allow sites to track your
physical location,<br><var>block</var>: Don't allow sites to track your physical
location,<br><var>ask</var>: Ask before allowing sites to track your physical
location. <br>Default is <var>ask</var>.<br>The primary URL is the main-frame
URL. The secondary URL is not used.",
I think the primary URL is the requesting iframe, the secondary URL is the
embedding iframe (i.e. main frame).

[not at google - send to devlin, 2015-01-12 23:19:26]

lgtm when bauerb@ is happy

[Mike West, 2015-01-13 06:53:35]

Updated. bauerb@, mind taking another look?

https://codereview.chromium.org/843413003/diff/1/chrome/common/extensions/api...
File chrome/common/extensions/api/content_settings.json (right):

https://codereview.chromium.org/843413003/diff/1/chrome/common/extensions/api...
chrome/common/extensions/api/content_settings.json:202: "description": "Whether
to allow Geolocation. One of <br><var>allow</var>: Allow sites to track your
physical location,<br><var>block</var>: Don't allow sites to track your physical
location,<br><var>block</var>: Ask before allowing sites to track your physical
location. <br>Default is <var>ask</var>.<br>The primary URL is the main-frame
URL. The secondary URL is not used.",
On 2015/01/12 11:37:40, msramek wrote:
> "<br><var>block</var>: Ask before"
> 
> s/block/ask/

Thanks! Fixed the typo.

[Bernhard Bauer, 2015-01-13 10:52:49]

https://codereview.chromium.org/843413003/diff/40001/chrome/common/extensions...
File chrome/common/extensions/api/content_settings.json (right):

https://codereview.chromium.org/843413003/diff/40001/chrome/common/extensions...
chrome/common/extensions/api/content_settings.json:202: "description": "Whether
to allow Geolocation. One of <br><var>allow</var>: Allow sites to track your
physical location,<br><var>block</var>: Don't allow sites to track your physical
location,<br><var>ask</var>: Ask before allowing sites to track your physical
location. <br>Default is <var>ask</var>.<br>The primary URL is the main-frame
URL. The secondary URL is the URL of the top-level frame.",
This comment still doesn't make much sense. The main frame _is_ the top-level
frame, no? ;-)

[Mike West, 2015-01-13 13:00:30]

https://codereview.chromium.org/843413003/diff/40001/chrome/common/extensions...
File chrome/common/extensions/api/content_settings.json (right):

https://codereview.chromium.org/843413003/diff/40001/chrome/common/extensions...
chrome/common/extensions/api/content_settings.json:202: "description": "Whether
to allow Geolocation. One of <br><var>allow</var>: Allow sites to track your
physical location,<br><var>block</var>: Don't allow sites to track your physical
location,<br><var>ask</var>: Ask before allowing sites to track your physical
location. <br>Default is <var>ask</var>.<br>The primary URL is the main-frame
URL. The secondary URL is the URL of the top-level frame.",
On 2015/01/13 10:52:49, Bernhard Bauer wrote:
> This comment still doesn't make much sense. The main frame _is_ the top-level
> frame, no? ;-)

The main frame is the frame of the document whose URL is being tested. That is,
if example.com frames notexample.com, and notexample.com requests geolocation
data, notexample.com would be the "main frame", and example.com would be the
"top-level" frame.

This is consistent with the rest of the properties here, though I agree that it
could be phrased better. We should either run with "main-frame" here as well, or
change them all.

[Bernhard Bauer, 2015-01-13 23:09:38]

Apologies for the late reply, I was not in front of a computer all day (I know;
I'm as shocked as you are).

https://codereview.chromium.org/843413003/diff/40001/chrome/common/extensions...
File chrome/common/extensions/api/content_settings.json (right):

https://codereview.chromium.org/843413003/diff/40001/chrome/common/extensions...
chrome/common/extensions/api/content_settings.json:202: "description": "Whether
to allow Geolocation. One of <br><var>allow</var>: Allow sites to track your
physical location,<br><var>block</var>: Don't allow sites to track your physical
location,<br><var>ask</var>: Ask before allowing sites to track your physical
location. <br>Default is <var>ask</var>.<br>The primary URL is the main-frame
URL. The secondary URL is the URL of the top-level frame.",
On 2015/01/13 13:00:30, Mike West wrote:
> On 2015/01/13 10:52:49, Bernhard Bauer wrote:
> > This comment still doesn't make much sense. The main frame _is_ the
top-level
> > frame, no? ;-)
> 
> The main frame is the frame of the document whose URL is being tested. That
is,
> if http://example.com frames http://notexample.com, and http://notexample.com
requests geolocation
> data, http://notexample.com would be the "main frame", and http://example.com
would be the
> "top-level" frame.
> 
> This is consistent with the rest of the properties here, though I agree that
it
> could be phrased better. We should either run with "main-frame" here as well,
or
> change them all.

Not really. In other content setting types, "main-frame" does refer to the
top-level frame. For example, for plug-ins a content setting with primary URL
example.com governs whether plugins are allowed to run when example.com is
visible in the omnibox. This definition of "main frame" also matches what is
returned by RenderView::GetMainRenderFrame() et al. So if you want to use the
term "main-frame"[1] here, it should be used for the secondary URL.

[1] We should probably lose the dash here, but that's a change to make for all
content setting types in one go.

[Mike West, 2015-01-14 10:35:57]

Reworded after a quick chat. bauerb@, does this work for you?

[Bernhard Bauer, 2015-01-14 11:45:37]

LGTM, thanks!

[Mike West, 2015-01-14 11:47:54]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-01-14 11:48:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/843413003/60001

[commit-bot: I haz the power, 2015-01-14 12:47:17]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-14 12:48:15]

Patchset 4 (id:??) landed as
https://crrev.com/6b72640c72774ba56f537a17cf3b4b5f71e9e5dd
Cr-Commit-Position: refs/heads/master@{#311462}