Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 843233002: Don't check shareElement for attribute rules in SharedStyleFinder. (Closed)

Created:
5 years, 11 months ago by esprehn
Modified:
5 years, 11 months ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't check shareElement for attribute rules in SharedStyleFinder. There's no reason to do this, if an element matched an attribute rule then it'll have a unique style and RenderStyle::isSharable() will return false so we wouldn't even get here. If we could have matched an attribute rule, but didn't actually match one then we can continue to share with other elements that aren't affected by attribute rules since even though our attributes could affect styling the rules didn't match us. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/042308603aa4c134985b9cbfa3df9bb3d67be231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M sky/engine/core/css/resolver/SharedStyleFinder.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
esprehn
5 years, 11 months ago (2015-01-10 03:10:00 UTC) #1
ojan
lgtm
5 years, 11 months ago (2015-01-10 03:13:38 UTC) #2
esprehn
5 years, 11 months ago (2015-01-10 03:14:38 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
042308603aa4c134985b9cbfa3df9bb3d67be231 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698