Issue 843213002: Removing deprecated flag FLAGS_allow_truncated_connection_ids_for_quic

Issue 843213002: Removing deprecated flag FLAGS_allow_truncated_connection_ids_for_quic (Closed)

Created:
5 years, 11 months ago by ramant (doing other things)

Modified:
5 years, 11 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Removing deprecated flag FLAGS_allow_truncated_connection_ids_for_quic Merge internal change: 83439062 R=rch@chromium.org

Patch Set 2 : Removed cleanup changes that are not part of this CL #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -21 lines)			Patch
M	net/quic/quic_connection.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	net/quic/quic_connection_test.cc	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/quic/quic_flags.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	net/quic/quic_flags.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	net/quic/quic_stream_factory.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View		5 chunks	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/843213002/diff/1/net/quic/quic_headers_stream.cc File net/quic/quic_headers_stream.cc (right): https://codereview.chromium.org/843213002/diff/1/net/quic/quic_headers_stream.cc#newcode147 net/quic/quic_headers_stream.cc:147: CloseConnection("Unknown frame type received."); Was this part of ...

5 years, 11 months ago (2015-01-10 01:23:50 UTC) #2

ramant (doing other things)

https://codereview.chromium.org/843213002/diff/1/net/quic/quic_headers_stream.cc File net/quic/quic_headers_stream.cc (right): https://codereview.chromium.org/843213002/diff/1/net/quic/quic_headers_stream.cc#newcode147 net/quic/quic_headers_stream.cc:147: CloseConnection("Unknown frame type received."); On 2015/01/10 01:23:50, Ryan Hamilton ...

5 years, 11 months ago (2015-01-12 16:54:25 UTC) #3

ramant (doing other things)

5 years, 11 months ago (2015-01-13 03:14:01 UTC) #4

Hi Ryan,
  Deleted the cleanup changes that shouldn't have been part of this CL. Will
submit a separate CL for them.

thanks
raman

Expand Messages | Collapse Messages