Issue 8432003: Reduce leaking in object tracking tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8432003: Reduce leaking in object tracking tests (Closed)

Created:
9 years, 1 month ago by jar (doing other things)

Modified:
9 years, 1 month ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, brettw-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reduce leaking in object tracking tests Object tracking, by design, leaks data structures to avoid races at shutdown. This change adjusts the tests so that they can run leak-free. As a result, we can remove one of the generic suppressions that was giving the tests a free ride. r=rtenneti Closed by mistake.

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -21 lines)			Patch
M	base/tracked_objects.h	View	1 chunk	+9 lines, -5 lines	0 comments	Download
M	base/tracked_objects.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	base/tracked_objects_unittest.cc	View	3 chunks	+9 lines, -4 lines	0 comments	Download
M	tools/heapcheck/suppressions.txt	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages