Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Side by Side Diff: chromecast/browser/cast_content_browser_client.cc

Issue 843173002: Chromecast: propagate kEnableCrashReporter switch to child processes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/browser/cast_content_browser_client.h" 5 #include "chromecast/browser/cast_content_browser_client.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/files/scoped_file.h" 8 #include "base/files/scoped_file.h"
9 #include "base/i18n/rtl.h" 9 #include "base/i18n/rtl.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
107 107
108 void CastContentBrowserClient::AppendExtraCommandLineSwitches( 108 void CastContentBrowserClient::AppendExtraCommandLineSwitches(
109 base::CommandLine* command_line, 109 base::CommandLine* command_line,
110 int child_process_id) { 110 int child_process_id) {
111 111
112 std::string process_type = 112 std::string process_type =
113 command_line->GetSwitchValueNative(switches::kProcessType); 113 command_line->GetSwitchValueNative(switches::kProcessType);
114 base::CommandLine* browser_command_line = 114 base::CommandLine* browser_command_line =
115 base::CommandLine::ForCurrentProcess(); 115 base::CommandLine::ForCurrentProcess();
116 116
117 // IsCrashReporterEnabled() is set when InitCrashReporter() is called, and
118 // controlled by GetBreakpadClient()->EnableBreakpadForProcess(), therefore
119 // it's ok to add switch to every process here.
120 if (breakpad::IsCrashReporterEnabled()) {
121 command_line->AppendSwitch(switches::kEnableCrashReporter);
122 }
123
117 // Renderer process command-line 124 // Renderer process command-line
118 if (process_type == switches::kRendererProcess) { 125 if (process_type == switches::kRendererProcess) {
119 // Any browser command-line switches that should be propagated to 126 // Any browser command-line switches that should be propagated to
120 // the renderer go here. 127 // the renderer go here.
121 #if defined(OS_ANDROID) 128 #if defined(OS_ANDROID)
122 command_line->AppendSwitch(switches::kForceUseOverlayEmbeddedVideo); 129 command_line->AppendSwitch(switches::kForceUseOverlayEmbeddedVideo);
123 #endif // defined(OS_ANDROID) 130 #endif // defined(OS_ANDROID)
124 131
125 if (browser_command_line->HasSwitch(switches::kEnableCmaMediaPipeline)) 132 if (browser_command_line->HasSwitch(switches::kEnableCmaMediaPipeline))
126 command_line->AppendSwitch(switches::kEnableCmaMediaPipeline); 133 command_line->AppendSwitch(switches::kEnableCmaMediaPipeline);
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 process_type, dumps_path, false /* upload */); 333 process_type, dumps_path, false /* upload */);
327 // StartUploaderThread() even though upload is diferred. 334 // StartUploaderThread() even though upload is diferred.
328 // Breakpad-related memory is freed in the uploader thread. 335 // Breakpad-related memory is freed in the uploader thread.
329 crash_handler->StartUploaderThread(); 336 crash_handler->StartUploaderThread();
330 return crash_handler; 337 return crash_handler;
331 } 338 }
332 #endif // !defined(OS_ANDROID) 339 #endif // !defined(OS_ANDROID)
333 340
334 } // namespace shell 341 } // namespace shell
335 } // namespace chromecast 342 } // namespace chromecast
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698